Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 10544084: Fix crash when displaying system print dialog on Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extra render_view_id references Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/print_web_view_helper.cc
diff --git a/chrome/renderer/print_web_view_helper.cc b/chrome/renderer/print_web_view_helper.cc
index 97afa8626b823def58337de32be13be502aa12f9..bfcf5f9d5f9029a138a442e4acbb4de13654f243 100644
--- a/chrome/renderer/print_web_view_helper.cc
+++ b/chrome/renderer/print_web_view_helper.cc
@@ -1539,10 +1539,6 @@ bool PrintWebViewHelper::GetPrintSettingsFromUser(WebKit::WebFrame* frame,
PrintHostMsg_ScriptedPrint_Params params;
PrintMsg_PrintPages_Params print_settings;
- // host_window_ may be NULL at this point if the current window is a
- // popup and the print() command has been issued from the parent. The
- // receiver of this message has to deal with this.
- params.host_window_id = render_view()->GetHostWindow();
Lei Zhang 2012/06/11 23:32:28 FYI, this is the only user of GetHostWindow(). Sha
Albert Bodenhamer 2012/06/12 01:19:02 Done.
params.cookie = print_pages_params_->params.document_cookie;
params.has_selection = frame->hasSelection();
params.expected_pages_count = expected_pages_count;
« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/common/print_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698