Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10544083: Quick fix to skip invalid URLs in ExtensionDownloader. (Closed)

Created:
8 years, 6 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, asargent_no_longer_on_chrome
Visibility:
Public.

Description

Quick fix to skip invalid URLs in ExtensionDownloader. We don't know why they appear yet, but this fixes a crash. BUG=130881 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Aaron Boodman
Does this seem like it would 'fix' it?
8 years, 6 months ago (2012-06-08 22:37:35 UTC) #1
Aaron Boodman
+asargent, who's ooo today.
8 years, 6 months ago (2012-06-08 22:37:50 UTC) #2
Avi (use Gerrit)
That's certainly one way to band-aid the problem. LGTM for crash-avoidance, though the question of ...
8 years, 6 months ago (2012-06-08 22:44:16 UTC) #3
Aaron Boodman
On 2012/06/08 22:44:16, Avi wrote: > That's certainly one way to band-aid the problem. LGTM ...
8 years, 6 months ago (2012-06-08 22:48:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10544083/1
8 years, 6 months ago (2012-06-08 22:49:06 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-09 00:29:55 UTC) #6
Change committed as 141332

Powered by Google App Engine
This is Rietveld 408576698