Issue 10544076: Changes to run Swarm from the Editor and to suppress warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544076: Changes to run Swarm from the Editor and to suppress warnings. (Closed)

Created:
8 years, 6 months ago by vsm

Modified:
8 years, 6 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Changes to run Swarm from the Editor and to suppress warnings. Note: this will likely break app-engine. Committed: https://code.google.com/p/dart/source/detail?r=8495

Patch Set 2 : Restore dart.js link #

Patch Set 4 : Clean up a constructor #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
M	samples/swarm/App.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/DataSource.dart	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	samples/swarm/SwarmViews.dart	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	samples/swarm/UIState.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/ui_lib/view/view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgrove

lgtm https://chromiumcodereview.appspot.com/10544076/diff/4001/samples/swarm/SwarmViews.dart File samples/swarm/SwarmViews.dart (right): https://chromiumcodereview.appspot.com/10544076/diff/4001/samples/swarm/SwarmViews.dart#newcode814 samples/swarm/SwarmViews.dart:814: '<canvas width="${img.width}" height="${img.height}"></canvas>'); What about final canvas = ...

8 years, 6 months ago (2012-06-11 15:37:29 UTC) #2

vsm

8 years, 6 months ago (2012-06-11 15:55:14 UTC) #3

On 2012/06/11 15:37:29, dgrove wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10544076/diff/4001/samples/swarm/Swarm...
> File samples/swarm/SwarmViews.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10544076/diff/4001/samples/swarm/Swarm...
> samples/swarm/SwarmViews.dart:814: '<canvas width="${img.width}"
> height="${img.height}"></canvas>');
> What about
> 
> final canvas = new CanvasElement(img.width, img.height);
> 
> ?

Thanks, done.  Still have a good bit of this sort of clean up to do.  Landed.