Issue 10544075: Remove NPChannelBase from cache on error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544075: Remove NPChannelBase from cache on error. (Closed)

Created:
8 years, 6 months ago by Scott Hess - ex-Googler

Modified:
8 years, 6 months ago

Reviewers:
brettw, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove NPChannelBase from cache on error. Normal channel shutdown (as for navigation) goes via RemoveRoute(), which removes the channel from the cache. It looks like OnChannelError() is expected to call RemoveRoute() at some point during cleanup, but sometimes the channel is left in the cache and re-vended (as measured by previous instrumentation). Defensively rename channels which see an error so that they aren't found in the cache in the future. BUG=97285 TEST=no user-visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141279