Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 10544069: Change platform app api getDisplayPath to take FileEntry. (Closed)

Created:
8 years, 6 months ago by benwells
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, kinuko+watch, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Change platform app api getDisplayPath to take FileEntry. Previously it has been taking a file system name and relative file. Now the API takes a FileEntry which is much nicer to use, and is transformed into a file system name and relative file path for the implementation via a custom binding. BUG=130452 TEST=The existing automated test has been updated Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141186

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/file_system.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/renderer/resources/extensions/file_system_custom_bindings.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/get_display_path/test.js View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
8 years, 6 months ago (2012-06-08 05:46:11 UTC) #1
koz (OOO until 15th September)
lgtm
8 years, 6 months ago (2012-06-08 06:08:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10544069/2001
8 years, 6 months ago (2012-06-08 06:13:26 UTC) #3
commit-bot: I haz the power
Try job failure for 10544069-2001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-08 07:59:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10544069/2001
8 years, 6 months ago (2012-06-08 08:10:10 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 09:09:20 UTC) #6
Change committed as 141186

Powered by Google App Engine
This is Rietveld 408576698