Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10544068: Issue 3307. Report error when built-in identifier used as type annotation (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3307. Report error when built-in identifier used as type annotation http://code.google.com/p/dart/issues/detail?id=3307 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8476

Patch Set 1 #

Patch Set 2 : Status file changes after new co19 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -15 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 4 chunks +11 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 2 chunks +11 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 1 chunk +58 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 3 chunks +1 line, -13 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 6 months ago (2012-06-08 05:07:16 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-08 15:19:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698