Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: chrome/test/data/extensions/api_test/i18n/test.js

Issue 10544066: Double dollar ($$) parsing in messages.json broken (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/i18n/_locales/en_US/messages.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // i18n api test 5 // i18n api test
6 // browser_tests.exe --gtest_filter=ExtensionApiTest.I18N --lib=browser_tests 6 // browser_tests.exe --gtest_filter=ExtensionApiTest.I18N --lib=browser_tests
7 7
8 var testCallback = chrome.test.testCallback; 8 var testCallback = chrome.test.testCallback;
9 var callbackPass = chrome.test.callbackPass; 9 var callbackPass = chrome.test.callbackPass;
10 10
11 chrome.test.getConfig(function(config) { 11 chrome.test.getConfig(function(config) {
12 12
13 var TEST_FILE_URL = "http://localhost:PORT/files/extensions/test_file.html" 13 var TEST_FILE_URL = "http://localhost:PORT/files/extensions/test_file.html"
14 .replace(/PORT/, config.testServer.port); 14 .replace(/PORT/, config.testServer.port);
15 15
16 chrome.test.runTests([ 16 chrome.test.runTests([
17 function getAcceptLanguages() { 17 function getAcceptLanguages() {
18 chrome.i18n.getAcceptLanguages(callbackPass(function(results) { 18 chrome.i18n.getAcceptLanguages(callbackPass(function(results) {
19 chrome.test.assertEq(results.length, 2); 19 chrome.test.assertEq(results.length, 2);
20 chrome.test.assertEq(results[0], "en-US"); 20 chrome.test.assertEq(results[0], "en-US");
21 chrome.test.assertEq(results[1], "en"); 21 chrome.test.assertEq(results[1], "en");
22 })); 22 }));
23 }, 23 },
24 function getMessage() { 24 function getMessage() {
25 var message = chrome.i18n.getMessage("simple_message"); 25 var message = chrome.i18n.getMessage("simple_message");
26 chrome.test.assertEq(message, "Simple message"); 26 chrome.test.assertEq(message, "Simple message");
27 27
28 message = chrome.i18n.getMessage("message_with_placeholders", 28 message = chrome.i18n.getMessage("message_with_placeholders",
29 ["Cira", "John"]); 29 ["Cira", "John"]);
30 chrome.test.assertEq(message, "Cira and John work for Google"); 30 chrome.test.assertEq(message, "Cira and John work for Google");
31 31
32 message = chrome.i18n.getMessage("message_with_one_placeholder", "19"); 32 message = chrome.i18n.getMessage("message_with_one_placeholder", "19");
33 chrome.test.assertEq(message, "Number of errors: 19"); 33 chrome.test.assertEq(message, "Number of errors: 19");
34 34
35 message = chrome.i18n.getMessage("message_with_double_dollar_sign");
36 chrome.test.assertEq(message, "I need $500 please.");
37
38 message = chrome.i18n.getMessage(
39 "message_with_double_dollar_sign_and_placeholders",
40 ["Mitchell", "Chris"]);
41 chrome.test.assertEq(message,
42 "We should really be paying Mitchell and Chris more $$$.");
Matt Perry 2012/06/08 19:09:42 $$$$ becomes $$$? Shouldn't it be $$?
43
35 chrome.test.succeed(); 44 chrome.test.succeed();
36 }, 45 },
37 function getMessageFromContentScript() { 46 function getMessageFromContentScript() {
38 chrome.extension.onRequest.addListener( 47 chrome.extension.onRequest.addListener(
39 function(request, sender, sendResponse) { 48 function(request, sender, sendResponse) {
40 chrome.test.assertEq(request, "Number of errors: 19"); 49 chrome.test.assertEq(request, "Number of errors: 19");
41 } 50 }
42 ); 51 );
43 chrome.test.log("Creating tab..."); 52 chrome.test.log("Creating tab...");
44 chrome.tabs.create({ 53 chrome.tabs.create({
45 url: TEST_FILE_URL 54 url: TEST_FILE_URL
46 }); 55 });
47 chrome.test.succeed(); 56 chrome.test.succeed();
48 } 57 }
49 ]); 58 ]);
50 }); 59 });
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/i18n/_locales/en_US/messages.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698