Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 10544060: Merge 140030 - Revert 124453 - WebWidgetClient::screenInfo() no longer does a synchronous IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1132/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 const content::RendererPreferences& renderer_prefs, 433 const content::RendererPreferences& renderer_prefs,
434 const WebPreferences& webkit_prefs, 434 const WebPreferences& webkit_prefs,
435 SharedRenderViewCounter* counter, 435 SharedRenderViewCounter* counter,
436 int32 routing_id, 436 int32 routing_id,
437 int32 surface_id, 437 int32 surface_id,
438 int64 session_storage_namespace_id, 438 int64 session_storage_namespace_id,
439 const string16& frame_name, 439 const string16& frame_name,
440 bool is_renderer_created, 440 bool is_renderer_created,
441 bool swapped_out, 441 bool swapped_out,
442 int32 next_page_id, 442 int32 next_page_id,
443 const WebKit::WebScreenInfo& screen_info,
444 bool guest, 443 bool guest,
445 AccessibilityMode accessibility_mode) 444 AccessibilityMode accessibility_mode)
446 : RenderWidget(WebKit::WebPopupTypeNone, screen_info, swapped_out), 445 : RenderWidget(WebKit::WebPopupTypeNone, swapped_out),
447 webkit_preferences_(webkit_prefs), 446 webkit_preferences_(webkit_prefs),
448 send_content_state_immediately_(false), 447 send_content_state_immediately_(false),
449 enabled_bindings_(0), 448 enabled_bindings_(0),
450 send_preferred_size_changes_(false), 449 send_preferred_size_changes_(false),
451 is_loading_(false), 450 is_loading_(false),
452 navigation_gesture_(NavigationGestureUnknown), 451 navigation_gesture_(NavigationGestureUnknown),
453 opened_by_user_gesture_(true), 452 opened_by_user_gesture_(true),
454 opener_suppressed_(false), 453 opener_suppressed_(false),
455 page_id_(-1), 454 page_id_(-1),
456 last_page_id_sent_to_browser_(-1), 455 last_page_id_sent_to_browser_(-1),
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 const content::RendererPreferences& renderer_prefs, 649 const content::RendererPreferences& renderer_prefs,
651 const WebPreferences& webkit_prefs, 650 const WebPreferences& webkit_prefs,
652 SharedRenderViewCounter* counter, 651 SharedRenderViewCounter* counter,
653 int32 routing_id, 652 int32 routing_id,
654 int32 surface_id, 653 int32 surface_id,
655 int64 session_storage_namespace_id, 654 int64 session_storage_namespace_id,
656 const string16& frame_name, 655 const string16& frame_name,
657 bool is_renderer_created, 656 bool is_renderer_created,
658 bool swapped_out, 657 bool swapped_out,
659 int32 next_page_id, 658 int32 next_page_id,
660 const WebKit::WebScreenInfo& screen_info,
661 bool guest, 659 bool guest,
662 AccessibilityMode accessibility_mode) { 660 AccessibilityMode accessibility_mode) {
663 DCHECK(routing_id != MSG_ROUTING_NONE); 661 DCHECK(routing_id != MSG_ROUTING_NONE);
664 return new RenderViewImpl( 662 return new RenderViewImpl(
665 parent_hwnd, 663 parent_hwnd,
666 opener_id, 664 opener_id,
667 renderer_prefs, 665 renderer_prefs,
668 webkit_prefs, 666 webkit_prefs,
669 counter, 667 counter,
670 routing_id, 668 routing_id,
671 surface_id, 669 surface_id,
672 session_storage_namespace_id, 670 session_storage_namespace_id,
673 frame_name, 671 frame_name,
674 is_renderer_created, 672 is_renderer_created,
675 swapped_out, 673 swapped_out,
676 next_page_id, 674 next_page_id,
677 screen_info,
678 guest, 675 guest,
679 accessibility_mode); 676 accessibility_mode);
680 } 677 }
681 678
682 WebPeerConnectionHandler* RenderViewImpl::CreatePeerConnectionHandler( 679 WebPeerConnectionHandler* RenderViewImpl::CreatePeerConnectionHandler(
683 WebPeerConnectionHandlerClient* client) { 680 WebPeerConnectionHandlerClient* client) {
684 EnsureMediaStreamImpl(); 681 EnsureMediaStreamImpl();
685 if (!media_stream_impl_) 682 if (!media_stream_impl_)
686 return NULL; 683 return NULL;
687 return media_stream_impl_->CreatePeerConnectionHandler(client); 684 return media_stream_impl_->CreatePeerConnectionHandler(client);
(...skipping 846 matching lines...) Expand 10 before | Expand all | Expand 10 after
1534 renderer_preferences_, 1531 renderer_preferences_,
1535 webkit_preferences_, 1532 webkit_preferences_,
1536 shared_popup_counter_, 1533 shared_popup_counter_,
1537 routing_id, 1534 routing_id,
1538 surface_id, 1535 surface_id,
1539 cloned_session_storage_namespace_id, 1536 cloned_session_storage_namespace_id,
1540 frame_name, 1537 frame_name,
1541 true, 1538 true,
1542 false, 1539 false,
1543 1, 1540 1,
1544 screen_info_,
1545 guest_, 1541 guest_,
1546 accessibility_mode_); 1542 accessibility_mode_);
1547 view->opened_by_user_gesture_ = params.user_gesture; 1543 view->opened_by_user_gesture_ = params.user_gesture;
1548 1544
1549 // Record whether the creator frame is trying to suppress the opener field. 1545 // Record whether the creator frame is trying to suppress the opener field.
1550 view->opener_suppressed_ = params.opener_suppressed; 1546 view->opener_suppressed_ = params.opener_suppressed;
1551 1547
1552 // Record the security origin of the creator. 1548 // Record the security origin of the creator.
1553 GURL creator_url(creator->document().securityOrigin().toString().utf8()); 1549 GURL creator_url(creator->document().securityOrigin().toString().utf8());
1554 if (!creator_url.is_valid() || !creator_url.IsStandard()) 1550 if (!creator_url.is_valid() || !creator_url.IsStandard())
1555 creator_url = GURL(); 1551 creator_url = GURL();
1556 view->creator_url_ = creator_url; 1552 view->creator_url_ = creator_url;
1557 1553
1558 // Copy over the alternate error page URL so we can have alt error pages in 1554 // Copy over the alternate error page URL so we can have alt error pages in
1559 // the new render view (we don't need the browser to send the URL back down). 1555 // the new render view (we don't need the browser to send the URL back down).
1560 view->alternate_error_page_url_ = alternate_error_page_url_; 1556 view->alternate_error_page_url_ = alternate_error_page_url_;
1561 1557
1562 return view->webview(); 1558 return view->webview();
1563 } 1559 }
1564 1560
1565 WebWidget* RenderViewImpl::createPopupMenu(WebKit::WebPopupType popup_type) { 1561 WebWidget* RenderViewImpl::createPopupMenu(WebKit::WebPopupType popup_type) {
1566 RenderWidget* widget = 1562 RenderWidget* widget =
1567 RenderWidget::Create(routing_id_, popup_type, screen_info_); 1563 RenderWidget::Create(routing_id_, popup_type);
1568 return widget->webwidget(); 1564 return widget->webwidget();
1569 } 1565 }
1570 1566
1571 WebWidget* RenderViewImpl::createPopupMenu(const WebPopupMenuInfo& info) { 1567 WebWidget* RenderViewImpl::createPopupMenu(const WebPopupMenuInfo& info) {
1572 // TODO(jcivelli): Remove this deprecated method when its been removed from 1568 // TODO(jcivelli): Remove this deprecated method when its been removed from
1573 // the WebViewClient interface. It's been replaced by 1569 // the WebViewClient interface. It's been replaced by
1574 // createExternalPopupMenu. 1570 // createExternalPopupMenu.
1575 NOTREACHED(); 1571 NOTREACHED();
1576 return NULL; 1572 return NULL;
1577 } 1573 }
(...skipping 3732 matching lines...) Expand 10 before | Expand all | Expand 10 after
5310 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const { 5306 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
5311 return !!RenderThreadImpl::current()->compositor_thread(); 5307 return !!RenderThreadImpl::current()->compositor_thread();
5312 } 5308 }
5313 5309
5314 void RenderViewImpl::OnJavaBridgeInit() { 5310 void RenderViewImpl::OnJavaBridgeInit() {
5315 DCHECK(!java_bridge_dispatcher_.get()); 5311 DCHECK(!java_bridge_dispatcher_.get());
5316 #if defined(ENABLE_JAVA_BRIDGE) 5312 #if defined(ENABLE_JAVA_BRIDGE)
5317 java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this)); 5313 java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this));
5318 #endif 5314 #endif
5319 } 5315 }
OLDNEW
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698