Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6135)

Unified Diff: chrome/common/extensions/extension_manifest_constants.cc

Issue 10544059: Change the platform app manifest structure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_manifest_constants.h ('k') | chrome/common/extensions/manifest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_manifest_constants.cc
diff --git a/chrome/common/extensions/extension_manifest_constants.cc b/chrome/common/extensions/extension_manifest_constants.cc
index 2fda6da66dc3065b87834824580536ded234c597..2ae9de8911a821a9f0ec598f6ab1eb8f4bb6f308 100644
--- a/chrome/common/extensions/extension_manifest_constants.cc
+++ b/chrome/common/extensions/extension_manifest_constants.cc
@@ -85,7 +85,9 @@ const char kPageActionPopup[] = "popup";
const char kPageActionPopupPath[] = "path";
const char kPageActions[] = "page_actions";
const char kPermissions[] = "permissions";
-const char kPlatformApp[] = "platform_app";
+const char kPlatformAppBackground[] = "app.background";
+const char kPlatformAppBackgroundPage[] = "app.background.page";
+const char kPlatformAppBackgroundScripts[] = "app.background.scripts";
const char kPlugins[] = "plugins";
const char kPluginsPath[] = "path";
const char kPluginsPublic[] = "public";
@@ -475,6 +477,12 @@ const char kPlatformAppFlagRequired[] =
"Loading platform_app extension type is turned off by default. "
miket_OOO 2012/06/07 21:34:19 If we want to be platform_app-clean after this CL,
Mihai Parparita -not on Chrome 2012/06/07 21:40:01 I think there's more strings than just these, so I
"You can enable this type with the --enable-platform-apps "
"command-line flag.";
+const char kPlatformAppInvalidBackgroundPage[] =
+ "Platform app background pages are specified via the "
+ "app.background.page key.";
miket_OOO 2012/06/07 21:34:19 Do we want to call these just "apps" rather than "
Mihai Parparita -not on Chrome 2012/06/07 21:40:01 Same as above (and see discussion in my bug commen
+const char kPlatformAppInvalidBackgroundScripts[] =
+ "Platform app background scripts are specified via the "
+ "app.background.scripts key.";
const char kPlatformAppNeedsManifestVersion2[] =
"Platform apps need manifest_version set to >= 2";
const char kReservedMessageFound[] =
« no previous file with comments | « chrome/common/extensions/extension_manifest_constants.h ('k') | chrome/common/extensions/manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698