Issue 10544050: Set the Android disk cache location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544050: Set the Android disk cache location (Closed)

Created:
8 years, 6 months ago by haitao.feng

Modified:
8 years, 6 months ago

Reviewers:
michaelbai, John Grabowski, Ted C, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, yongsheng, Shouqun Liu, Ted C

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Set the Android disk cache location BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141151

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	content/shell/shell_browser_context.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

I am not sure whether to keep "#else NOTIMPLEMENTED();". Will there be a content shell ...

8 years, 6 months ago (2012-06-07 06:53:30 UTC) #1

John Grabowski

Looks correct; cc tedchoc in case I'm missing the point somehow. Adding jam for OWNERS ...

8 years, 6 months ago (2012-06-07 17:51:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitao.feng@intel.com/10544050/1

8 years, 6 months ago (2012-06-08 00:12:27 UTC) #5

Change committed as 141151

Expand Messages | Collapse Messages