Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10544049: ninja windows: support alternative entrypoints. (Closed)

Created:
8 years, 6 months ago by grt (UTC plus 2)
Modified:
8 years, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: support alternative entrypoints. 'EntryPointSymbol' translates to /ENTRY: in linker flags. This is needed by Chrome's mini_installer target. BUG=none TEST=python gyptest.py -f msvs,ninja test/win/gyptest-link-entrypointsymbol.py Committed: https://code.google.com/p/gyp/source/detail?r=1412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -0 lines 0 comments Download
A test/win/gyptest-link-entrypointsymbol.py View 1 chunk +24 lines, -0 lines 0 comments Download
A test/win/linker-flags/entrypointsymbol.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A test/win/linker-flags/entrypointsymbol.gyp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
grt (UTC plus 2)
8 years, 6 months ago (2012-06-07 04:58:04 UTC) #1
scottmg
8 years, 6 months ago (2012-06-07 17:55:23 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698