Fix ScreenLocker to not send notifications with empty passwords.

chrome/browser/chromeos/login/screen_locker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/screen_locker.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 168 matching lines @@
   if (authentication_start_time_.is_null()) {
     if (!username.empty())
       LOG(WARNING) << "authentication_start_time_ is not set";
   } else {
     base::TimeDelta delta = base::Time::Now() - authentication_start_time_;
     VLOG(1) << "Authentication success time: " << delta.InSecondsF();
     UMA_HISTOGRAM_TIMES("ScreenLocker.AuthenticationSuccessTime", delta);
   }
 
   Profile* profile = ProfileManager::GetDefaultProfile();
-  if (profile) {
-    ProfileSyncService* service(
-        ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile));
-    if (service && !service->HasSyncSetupCompleted()) {
-      SigninManager* signin = SigninManagerFactory::GetForProfile(profile);
-      DCHECK(signin);
-      GoogleServiceSigninSuccessDetails details(
-          signin->GetAuthenticatedUsername(),
-          password);
-      content::NotificationService::current()->Notify(
-          chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
-          content::Source<Profile>(profile),
-          content::Details<const GoogleServiceSigninSuccessDetails>(&details));
-    }
+  if (profile && !password.empty()) {
+    // We have a non-empty password, so notify listeners (such as the sync
+    // engine).
+    SigninManager* signin = SigninManagerFactory::GetForProfile(profile);
+    DCHECK(signin);
+    GoogleServiceSigninSuccessDetails details(
+        signin->GetAuthenticatedUsername(),
+        password);
+    content::NotificationService::current()->Notify(
+        chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
+        content::Source<Profile>(profile),
+        content::Details<const GoogleServiceSigninSuccessDetails>(&details));
   }
   DBusThreadManager::Get()->GetPowerManagerClient()->
       NotifyScreenUnlockRequested();
 
   if (login_status_consumer_)
     login_status_consumer_->OnLoginSuccess(username, password, pending_requests,
                                            using_oauth);
 }
 
 void ScreenLocker::Authenticate(const string16& password) {
@@ skipping 153 matching lines @@
   bool state = true;
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_SCREEN_LOCK_STATE_CHANGED,
       content::Source<ScreenLocker>(this),
       content::Details<bool>(&state));
   DBusThreadManager::Get()->GetPowerManagerClient()->
       NotifyScreenLockCompleted();
 }
 
 }  // namespace chromeos