Issue 10544034: gdata: Fix a crash at shutdown with pending gdata operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544034: gdata: Fix a crash at shutdown with pending gdata operations (Closed)

Created:
8 years, 6 months ago by satorux1

Modified:
8 years, 6 months ago

Reviewers:
zel

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Fix a crash at shutdown with pending gdata operations Before the fix, chromeos::SystemTrayDelegate didn't remove itself as an oberver of GDataOperationRegistry. This resulted in a crash at shutdown as OnProgressUpdate() was called against chromeos::SystemTrayDelegate, which was already deleted. BUG=131309 TEST=confirm the crash is gone per repro steps at crbug.com/131309#c5 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140889

Patch Set 1 #

Patch Set 2 : fix RemoteFileSystemExtensionApiTest.RemoteMountPoint #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	chrome/browser/chromeos/extensions/external_filesystem_apitest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages