Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents.h

Issue 10544033: TabContentsWrapper -> TabContents, part 3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_ 6 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // that do not have a TabContents include: 80 // that do not have a TabContents include:
81 // - Extension background pages and popup bubbles 81 // - Extension background pages and popup bubbles
82 // - HTML notification bubbles 82 // - HTML notification bubbles
83 // - Screensavers on Chrome OS 83 // - Screensavers on Chrome OS
84 // - Other random places we decide to display HTML over time 84 // - Other random places we decide to display HTML over time
85 // 85 //
86 // Consider carefully whether your feature is something that makes sense only 86 // Consider carefully whether your feature is something that makes sense only
87 // when a tab is displayed, or could make sense in other cases we use HTML. It 87 // when a tab is displayed, or could make sense in other cases we use HTML. It
88 // may makes sense to push down into WebContents and make configurable, or at 88 // may makes sense to push down into WebContents and make configurable, or at
89 // least to make easy for other WebContents hosts to include and support. 89 // least to make easy for other WebContents hosts to include and support.
90 //
91 // TODO(avi): Eventually, this class will become TabContents as far as
92 // the browser front-end is concerned.
93 class TabContents : public content::WebContentsObserver { 90 class TabContents : public content::WebContentsObserver {
94 public: 91 public:
95 // Takes ownership of |contents|, which must be heap-allocated (as it lives 92 // Takes ownership of |contents|, which must be heap-allocated (as it lives
96 // in a scoped_ptr) and can not be NULL. 93 // in a scoped_ptr) and can not be NULL.
97 explicit TabContents(content::WebContents* contents); 94 explicit TabContents(content::WebContents* contents);
98 virtual ~TabContents(); 95 virtual ~TabContents();
99 96
100 // Create a TabContents with the same state as this one. The returned 97 // Create a TabContents with the same state as this one. The returned
101 // heap-allocated pointer is owned by the caller. 98 // heap-allocated pointer is owned by the caller.
102 TabContents* Clone(); 99 TabContents* Clone();
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 310
314 // The supporting objects need to outlive the WebContents dtor (as they may 311 // The supporting objects need to outlive the WebContents dtor (as they may
315 // be called upon during its execution). As a result, this must come last 312 // be called upon during its execution). As a result, this must come last
316 // in the list. 313 // in the list.
317 scoped_ptr<content::WebContents> web_contents_; 314 scoped_ptr<content::WebContents> web_contents_;
318 315
319 DISALLOW_COPY_AND_ASSIGN(TabContents); 316 DISALLOW_COPY_AND_ASSIGN(TabContents);
320 }; 317 };
321 318
322 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_ 319 #endif // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698