Issue 10544025: Cleanup Runtime_SetCode and drop EnsureCompiled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544025: Cleanup Runtime_SetCode and drop EnsureCompiled. (Closed)

Created:
8 years, 6 months ago by Michael Starzinger

Modified:
8 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup Runtime_SetCode and drop EnsureCompiled. This change triggers compilation for a given closure instead of the shared function info. It will allow for even more cases to be compiled lazily. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11726

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -50 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+48 lines, -50 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/10544025/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10544025/diff/1/src/runtime.cc#newcode2203 src/runtime.cc:2203: target_shared->code()->set_optimizable(false); target_share->code() == source_shared->code() at this point, so ...

8 years, 6 months ago (2012-06-06 09:44:15 UTC) #2

Michael Starzinger

8 years, 6 months ago (2012-06-06 09:51:01 UTC) #3

https://chromiumcodereview.appspot.com/10544025/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10544025/diff/1/src/runtime.cc#newcode...
src/runtime.cc:2203: target_shared->code()->set_optimizable(false);
On 2012/06/06 09:44:15, ulan wrote:
> target_share->code() == source_shared->code() at this point, so one of the
calls
> is redundant. Is it here for consistency/readability?

Done. It was a leftover from the original version.

Expand Messages | Collapse Messages