Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 10544011: chromeos: Notify power manager about user activity. (Closed)

Created:
8 years, 6 months ago by Daniel Erat
Modified:
8 years, 6 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Simon Que
Visibility:
Public.

Description

chromeos: Notify power manager about user activity. This makes Chrome call powerd's HandleUserActivity D-Bus method in response to input events (but no more often than once every five seconds). BUG=chromium-os:31351 TEST=manual: tailed powerd's log and saw that it's receiving HandleUserActivity calls every five seconds as i type or move the mouse Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140849

Patch Set 1 #

Total comments: 4

Patch Set 2 : apply review feedback #

Patch Set 3 : RootWindowEventFilter -> EnvEventFilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -19 lines) Patch
M ash/ash.gyp View 1 2 2 chunks +13 lines, -10 lines 0 comments Download
M ash/shell.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
A ash/wm/user_activity_detector.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A ash/wm/user_activity_detector.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download
A ash/wm/user_activity_observer.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +5 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/power/user_activity_notifier.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/power/user_activity_notifier.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_power_manager_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
Steven: chromeos/ and chrome/browser/chromeos/ Scott: ash/
8 years, 6 months ago (2012-06-05 19:39:43 UTC) #1
stevenjb
lgtm
8 years, 6 months ago (2012-06-05 20:04:36 UTC) #2
sky
LGTM https://chromiumcodereview.appspot.com/10544011/diff/1/ash/wm/user_activity_detector.h File ash/wm/user_activity_detector.h (right): https://chromiumcodereview.appspot.com/10544011/diff/1/ash/wm/user_activity_detector.h#newcode18 ash/wm/user_activity_detector.h:18: class ASH_EXPORT UserActivityObserver { nit: move into its ...
8 years, 6 months ago (2012-06-05 20:24:21 UTC) #3
Daniel Erat
http://codereview.chromium.org/10544011/diff/1/ash/wm/user_activity_detector.h File ash/wm/user_activity_detector.h (right): http://codereview.chromium.org/10544011/diff/1/ash/wm/user_activity_detector.h#newcode18 ash/wm/user_activity_detector.h:18: class ASH_EXPORT UserActivityObserver { On 2012/06/05 20:24:21, sky wrote: ...
8 years, 6 months ago (2012-06-05 20:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10544011/16
8 years, 6 months ago (2012-06-06 19:26:22 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-06 21:51:19 UTC) #6
Change committed as 140849

Powered by Google App Engine
This is Rietveld 408576698