chrome/browser/plugin_finder_unittest.cc - Issue 10544003: Infobar all unknown unsandboxed plug-ins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_finder_unittest.cc

Issue 10544003: Infobar all unknown unsandboxed plug-ins. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugin_finder_unittest.cc

diff --git a/chrome/browser/plugin_finder_unittest.cc b/chrome/browser/plugin_finder_unittest.cc

index d6afe1fb0a090626b8b5af031a2ea2ca1c16c874..bbafbc5715307f49a64f384b143e3bbbda10c097 100644

--- a/chrome/browser/plugin_finder_unittest.cc

+++ b/chrome/browser/plugin_finder_unittest.cc

@@ -22,8 +22,10 @@ TEST(PluginFinderTest, JsonSyntax) {

ASSERT_TRUE(plugin_it.value().GetAsDictionary(&plugin));

std::string dummy_str;

bool dummy_bool;

- EXPECT_TRUE(plugin->GetString("lang", &dummy_str));

- EXPECT_TRUE(plugin->GetString("url", &dummy_str));

+ if (plugin->HasKey("lang"))

+ EXPECT_TRUE(plugin->GetString("lang", &dummy_str));

+ if (plugin->HasKey("url"))

+ EXPECT_TRUE(plugin->GetString("url", &dummy_str));

EXPECT_TRUE(plugin->GetString("name", &dummy_str));

if (plugin->HasKey("help_url"))

EXPECT_TRUE(plugin->GetString("help_url", &dummy_str));

« no previous file with comments | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »