Infobar all unknown unsandboxed plug-ins.

Infobar all unknown unsandboxed plug-ins.

BUG=130743
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141197

[darin (slow to review), 2012-06-05 17:30:36]

LGTM!!

[darin (slow to review), 2012-06-05 17:32:16]

We may need some white-listing of certain sites.  I'm not sure how we should
manage that.  This seems like a good starting point though :-)

[jam, 2012-06-05 17:40:34]

please hold off on the plugin_test_base part of the change, and duplicate
setting always-authorize-plugins in all the places. once i get
content_browsertests up (next on my tasks), there will be different parent
classes for browser_tests, and so this part of the change will have to be
undone. note that at that point, we won't need to pass always-authorize-plugins
to content_browsertests

[Bernhard Bauer, 2012-06-05 17:47:56]

On 2012/06/05 17:40:34, John Abd-El-Malek wrote:
> please hold off on the plugin_test_base part of the change, and duplicate
> setting always-authorize-plugins in all the places. once i get
> content_browsertests up (next on my tasks), there will be different parent
> classes for browser_tests, and so this part of the change will have to be
> undone. note that at that point, we won't need to pass
always-authorize-plugins
> to content_browsertests

Would it make sense to have a separate base classes for plugin tests in chrome/
and content/? Then we would just need to move the --always-authorize-plugins
from the content/ one to the chrome/ one.

[jam, 2012-06-05 18:06:49]

On 2012/06/05 17:47:56, Bernhard Bauer wrote:
> On 2012/06/05 17:40:34, John Abd-El-Malek wrote:
> > please hold off on the plugin_test_base part of the change, and duplicate
> > setting always-authorize-plugins in all the places. once i get
> > content_browsertests up (next on my tasks), there will be different parent
> > classes for browser_tests, and so this part of the change will have to be
> > undone. note that at that point, we won't need to pass
> always-authorize-plugins
> > to content_browsertests
> 
> Would it make sense to have a separate base classes for plugin tests in
chrome/
> and content/? Then we would just need to move the --always-authorize-plugins
> from the content/ one to the chrome/ one.

I think it may be premature at this point. In chrome there's only one class that
uses it. In content, there are 3. I'm not sure we need a new base class for
setting the "kExtraPluginDir"; it also seems that this something that
browser_tests/content_browsertests should just do in their harness
automatically.

[jam, 2012-06-05 20:03:49]

lgtm

[commit-bot: I haz the power, 2012-06-08 10:07:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/10544003/12002

[commit-bot: I haz the power, 2012-06-08 11:29:04]

Change committed as 141197