[net/dns] Instrument DnsConfigService to measure performance and failures.

net/dns/dns_config_service_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_config_service_win.h"
 
 #include "base/logging.h"
 #include "base/win/windows_version.h"
 #include "net/dns/dns_protocol.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 168 matching lines @@
     for (size_t j = 0; !t.expected_nameservers[j].empty(); ++j) {
       IPAddressNumber ip;
       ASSERT_TRUE(ParseIPLiteralToNumber(t.expected_nameservers[j], &ip));
       int port = t.expected_ports[j];
       if (!port)
         port = dns_protocol::kDefaultPort;
       expected_nameservers.push_back(IPEndPoint(ip, port));
     }
 
     DnsConfig config;
-    bool result = internal::ConvertSettingsToDnsConfig(settings, &config);
-    bool expected_result = !expected_nameservers.empty();
-    ASSERT_EQ(expected_result, result);
+    internal::ConfigParseWinResult result =
+        internal::ConvertSettingsToDnsConfig(settings, &config);
+    internal::ConfigParseWinResult expected_result =
+        expected_nameservers.empty() ? internal::CONFIG_PARSE_WIN_NO_NAMESERVERS
+            : internal::CONFIG_PARSE_WIN_OK;
+    EXPECT_EQ(expected_result, result);
     EXPECT_EQ(expected_nameservers, config.nameservers);
-    if (result) {
+    if (result == internal::CONFIG_PARSE_WIN_OK) {
       ASSERT_EQ(1u, config.search.size());
       EXPECT_EQ(t.expected_suffix, config.search[0]);
     }
   }
 }
 
 TEST(DnsConfigServiceWinTest, ConvertSuffixSearch) {
   AdapterInfo infos[2] = {
     { IF_TYPE_USB, IfOperStatusUp, L"connection.suffix", { "1.0.0.1" } },
     { 0 },
@@ skipping 164 matching lines @@
         { { false }, { true, 3 } },
         { { true, 0 }, { true, 3 } },
       },
       { "a.b.c.d.e", "connection.suffix" },
     },
   };
 
   for (size_t i = 0; i < arraysize(cases); ++i) {
     const TestCase& t = cases[i];
     DnsConfig config;
-    ASSERT_TRUE(internal::ConvertSettingsToDnsConfig(t.input_settings,
-                                                     &config));
+    EXPECT_EQ(internal::CONFIG_PARSE_WIN_OK,
+              internal::ConvertSettingsToDnsConfig(t.input_settings, &config));
     std::vector<std::string> expected_search;
     for (size_t j = 0; !t.expected_search[j].empty(); ++j) {
       expected_search.push_back(t.expected_search[j]);
     }
     EXPECT_EQ(expected_search, config.search);
   }
 }
 
 TEST(DnsConfigServiceWinTest, AppendToMultiLabelName) {
   AdapterInfo infos[2] = {
@@ skipping 17 matching lines @@
     const TestCase& t = cases[i];
     internal::DnsSystemSettings settings = {
       CreateAdapterAddresses(infos),
       { false }, { false }, { false }, { false },
       { { false }, { false } },
       { { false }, { false } },
       { { false }, { false } },
       t.input,
     };
     DnsConfig config;
-    ASSERT_TRUE(internal::ConvertSettingsToDnsConfig(settings, &config));
+    EXPECT_EQ(internal::CONFIG_PARSE_WIN_OK,
+              internal::ConvertSettingsToDnsConfig(settings, &config));
     EXPECT_EQ(config.append_to_multi_label_name, t.expected_output);
   }
 }
 
 }  // namespace
 
 }  // namespace net