Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10543162: Upstream IPC message resolver tool. (Closed)

Created:
8 years, 6 months ago by John Knottenbelt
Modified:
8 years, 6 months ago
Reviewers:
Yaron
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Upstream IPC message resolver tool. This is a tool to process log files and resolve IPC messages to symbols. Processes a log file and translates message identifiers of the form [unknown type NNNNNN] to IPC messages. python tools/ipc_messages_log.py logcat.txt. e.g. logfile containing ipc 3915.3.1370207904 2147483647 S [unknown type 66372] will be transformed to: ipc 3915.3.1370207904 2147483647 S ViewMsg_SetCSSColors BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142681

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
A tools/ipc_messages_log.py View 1 1 chunk +168 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
John Knottenbelt
8 years, 6 months ago (2012-06-14 13:47:00 UTC) #1
Yaron
lgtm Please ensure gpylint passes. I assume this is equivalent to downstream. https://chromiumcodereview.appspot.com/10543162/diff/1/tools/ipc_messages_log.py File tools/ipc_messages_log.py ...
8 years, 6 months ago (2012-06-14 16:37:59 UTC) #2
John Knottenbelt
It passes gpylint except for one problem: C6304: 1: Invalid header. Must include a copyright ...
8 years, 6 months ago (2012-06-15 09:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10543162/4001
8 years, 6 months ago (2012-06-18 06:36:26 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-18 08:27:14 UTC) #5
Change committed as 142681

Powered by Google App Engine
This is Rietveld 408576698