src/profile-generator.cc - Issue 10543160: Workarround for: Chrome dev tools crashes when taking a heap snapshot of Docs offline shared worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profile-generator.cc

Issue 10543160: Workarround for: Chrome dev tools crashes when taking a heap snapshot of Docs offline shared worker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comment was adjusted Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profile-generator.cc

diff --git a/src/profile-generator.cc b/src/profile-generator.cc

index ca19f4aaaffea68b8a12e0764086bfa09ec5e06a..71725cca357d4e935144f78679b24eae4f65bd80 100644

--- a/src/profile-generator.cc

+++ b/src/profile-generator.cc

@@ -2692,6 +2692,10 @@ void V8HeapExplorer::TagGlobalObjects() {

Object* obj_document;

if (global_obj->GetProperty(*document_string)->ToObject(&obj_document) &&

obj_document->IsJSObject()) {

+ // FixMe: Workarround: SharedWorker's current Isolate has NULL context.

Yang 2012/06/14 10:43:59 typo "workaround".

+ // As result GetProperty(*url_string) will crash.

+ if (!Isolate::Current()->context() && obj_document->IsJSGlobalProxy())

+ continue;

JSObject* document = JSObject::cast(obj_document);

Object* obj_url;

if (document->GetProperty(*url_string)->ToObject(&obj_url) &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »