Issue 10543160: Workarround for: Chrome dev tools crashes when taking a heap snapshot of Docs offline shared worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10543160: Workarround for: Chrome dev tools crashes when taking a heap snapshot of Docs offline shared worker. (Closed)

Created:
8 years, 6 months ago by loislo

Modified:
8 years, 6 months ago

Reviewers:
not_yurys, alexeif, Yang, mnaganov

CC:
v8-dev, danno

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Workaround for: Chrome dev tools crashes when taking a heap snapshot of Docs offline shared worker. BUG=132727 TEST=none Committed: https://code.google.com/p/v8/source/detail?r=11813

Patch Set 1 #

Patch Set 2 : comment was adjusted #

Total comments: 1

Patch Set 3 : comment text was slightly changed #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/profile-generator.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 6 months ago (2012-06-14 10:43:59 UTC) #3

https://chromiumcodereview.appspot.com/10543160/diff/2002/src/profile-generat...
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10543160/diff/2002/src/profile-generat...
src/profile-generator.cc:2695: // FixMe: Workarround: SharedWorker's current
Isolate has NULL context.
typo "workaround".

Expand Messages | Collapse Messages