Do not toggle Applist with Search key press when accessibility is enabled.

ash/shell/shell_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell/shell_delegate_impl.h"
 
 #include "ash/shell/example_factory.h"
 #include "ash/shell/launcher_delegate_impl.h"
 #include "ash/shell/toplevel_window.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/partial_screenshot_view.h"
 #include "base/message_loop.h"
 #include "ui/aura/window.h"
 
 namespace ash {
 namespace shell {
 
 ShellDelegateImpl::ShellDelegateImpl()
     : watcher_(NULL),
       launcher_delegate_(NULL),
-      locked_(false) {
+      locked_(false),
+      spoken_feedback_enabled_(false) {
 }
 
 ShellDelegateImpl::~ShellDelegateImpl() {
 }
 
 void ShellDelegateImpl::SetWatcher(WindowWatcher* watcher) {
   watcher_ = watcher;
   if (launcher_delegate_)
     launcher_delegate_->set_watcher(watcher);
 }
@@ skipping 54 matching lines @@
 }
 
 void ShellDelegateImpl::ShowTaskManager() {
 }
 
 content::BrowserContext* ShellDelegateImpl::GetCurrentBrowserContext() {
   return Shell::GetInstance()->browser_context();
 }
 
 void ShellDelegateImpl::ToggleSpokenFeedback() {
+  spoken_feedback_enabled_ = !spoken_feedback_enabled_;

[dmazzoni, 2012/06/14 16:45:25]

This worries me slightly, I'm afraid it could get out of sync.

Spoken feedback is turned on in a couple of different places - not only via the
global shortcut but also by toggling the checkbox in the Options. It's also
persistent - i.e. it will turn on automatically on boot if the preference is
set.

The main toggle function is in
src/chrome/browser/chromeos/accessibility/accessibility_util.cc - I think you
need to hook into there, or read the preference directly in order to be 100%
sure that this state will always be the same.

[Yusuke Sato, 2012/06/14 16:57:15]

If I understand correctly, ash/shell/* files are just for building test
environment for Ash developers, and are not included in a production Chrome OS
image.

The real implementation of ShellDelegate::ToggleSpokenFeedback() and
ShellDelegate::IsSpokenFeedbackEnabled() are in
chrome/browser/ui/views/ash/chrome_shell_delegate.cc. As you can see in
https://chromiumcodereview.appspot.com/10543158/diff/7001/chrome/browser/ui/v...
, the ShellDelegate functions in the file correctly use
chromeos::accessibility:: utility functions as you suggested.

On 2012/06/14 16:45:25, Dominic Mazzoni wrote:

[dmazzoni, 2012/06/14 17:05:00]

Ah! Thanks, I didn't realize that. Looks good.

- Dominic

+}
+
+bool ShellDelegateImpl::IsSpokenFeedbackEnabled() const {
+  return spoken_feedback_enabled_;
 }
 
 app_list::AppListViewDelegate* ShellDelegateImpl::CreateAppListViewDelegate() {
   return ash::shell::CreateAppListViewDelegate();
 }
 
 void ShellDelegateImpl::StartPartialScreenshot(
     ash::ScreenshotDelegate* screenshot_delegate) {
   ash::PartialScreenshotView::StartPartialScreenshot(screenshot_delegate);
 }
@@ skipping 11 matching lines @@
 
 ash::UserWallpaperDelegate* ShellDelegateImpl::CreateUserWallpaperDelegate() {
   return NULL;
 }
 aura::client::UserActionClient* ShellDelegateImpl::CreateUserActionClient() {
   return NULL;
 }
 
 }  // namespace shell
 }  // namespace ash