Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: test/mjsunit/debug-script-breakpoints-nested.js

Issue 10543141: Enable lazy compilation for non-trivial outer contexts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/debug-script-breakpoints-closure.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 11 matching lines...) Expand all
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug 28 // Flags: --expose-debug-as debug
29 // Get the Debug object exposed from the debug context global object. 29 // Get the Debug object exposed from the debug context global object.
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 // Simple debug event handler which just counts the number of break points hit. 32 // Simple debug event handler which just counts the number of break points hit.
33 var break_point_hit_count; 33 var break_point_hit_count = 0;
34 34
35 function listener(event, exec_state, event_data, data) { 35 function listener(event, exec_state, event_data, data) {
36 if (event == Debug.DebugEvent.Break) { 36 if (event == Debug.DebugEvent.Break) {
37 break_point_hit_count++; 37 break_point_hit_count++;
38 } 38 }
39 }; 39 };
40 40
41 // Add the debug event listener. 41 // Add the debug event listener.
42 Debug.setListener(listener); 42 Debug.setListener(listener);
43 43
44 // Test function. 44 eval(
45 function f() {}; 45 "var inner;\n" +
46 "function outer() {\n" + // Non-trivial outer closure.
47 " var x = 5;\n" +
48 " function a() {\n" +
49 " var foo = 0, y = 7;\n" +
50 " function b() {\n" +
51 " var bar = 0, baz = 0, z = 11;\n" +
52 " function c() {\n" +
53 " return x + y + z;\n" + // Breakpoint line ( #8 )
54 " }\n" +
55 " inner = c;\n" +
56 " return c();\n" +
57 " }\n" +
58 " return b();\n" +
59 " }\n" +
60 " return a();\n" +
61 "}"
62 );
46 63
47 // This tests ignore of break points including the case with several 64 var script = Debug.findScript(outer);
48 // break points in the same location.
49 break_point_hit_count = 0;
50 65
51 // Set a breakpoint in f. 66 // The debugger triggers compilation of inner closures.
52 bp1 = Debug.setBreakPoint(f); 67 assertEquals(0, Debug.scriptBreakPoints().length);
68 var sbp = Debug.setScriptBreakPointById(script.id, 8);
69 assertEquals(1, Debug.scriptBreakPoints().length);
53 70
54 // Try ignore count of 1. 71 // The compiled outer closure should behave correctly.
55 Debug.changeBreakPointIgnoreCount(bp1, 1); 72 assertEquals(23, outer());
56 f();
57 assertEquals(0, break_point_hit_count);
58 f();
59 assertEquals(1, break_point_hit_count); 73 assertEquals(1, break_point_hit_count);
60 74
61 // Set another breakpoint in f at the same place. 75 // The compiled inner closure should behave correctly.
62 bp2 = Debug.setBreakPoint(f); 76 assertEquals(23, inner());
63 f();
64 assertEquals(2, break_point_hit_count); 77 assertEquals(2, break_point_hit_count);
65 78
66 // Set different ignore counts. 79 // Remove script break point.
67 Debug.changeBreakPointIgnoreCount(bp1, 2); 80 assertEquals(1, Debug.scriptBreakPoints().length);
68 Debug.changeBreakPointIgnoreCount(bp2, 4); 81 Debug.clearBreakPoint(sbp);
69 f(); 82 assertEquals(0, Debug.scriptBreakPoints().length);
70 assertEquals(2, break_point_hit_count);
71 f();
72 assertEquals(2, break_point_hit_count);
73 f();
74 assertEquals(3, break_point_hit_count);
75 f();
76 assertEquals(4, break_point_hit_count);
77
78 // Set different ignore counts (opposite).
79 Debug.changeBreakPointIgnoreCount(bp1, 4);
80 Debug.changeBreakPointIgnoreCount(bp2, 2);
81 f();
82 assertEquals(4, break_point_hit_count);
83 f();
84 assertEquals(4, break_point_hit_count);
85 f();
86 assertEquals(5, break_point_hit_count);
87 f();
88 assertEquals(6, break_point_hit_count);
89
OLDNEW
« no previous file with comments | « test/mjsunit/debug-script-breakpoints-closure.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698