Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: test/mjsunit/debug-script-breakpoints-closure.js

Issue 10543141: Enable lazy compilation for non-trivial outer contexts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/mjsunit/debug-script-breakpoints-nested.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11 matching lines...) Expand all
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --expose-debug-as debug 28 // Flags: --expose-debug-as debug
29 // Get the Debug object exposed from the debug context global object. 29 // Get the Debug object exposed from the debug context global object.
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 var script_number = 0; 32 // Simple debug event handler which just counts the number of break points hit.
33 var script_names = []; 33 var break_point_hit_count = 0;
34 var exception = null;
35 34
36 function listener(event, exec_state, event_data, data) { 35 function listener(event, exec_state, event_data, data) {
37 if (event == Debug.DebugEvent.BeforeCompile) { 36 if (event == Debug.DebugEvent.Break) {
38 event_data.script().setSource(event_data.script().source() + 37 break_point_hit_count++;
39 " //@ sourceURL=proper_location_" + (++script_number));
40 } else if (event == Debug.DebugEvent.AfterCompile) {
41 try {
42 event_data.script().setSource("a=1 //@ sourceURL=wrong_location");
43 } catch(e) {
44 exception = e;
45 }
46 script_names.push(event_data.script().name());
47 } 38 }
48 }; 39 };
49 40
50
51 // Add the debug event listener. 41 // Add the debug event listener.
52 Debug.setListener(listener); 42 Debug.setListener(listener);
53 43
54 // Compile different sources. 44 function makeClosure() {
55 eval('a=1'); 45 var x;
56 eval('(function(){})'); 46 return function() {
47 return x; // Breakpoint line ( #47 )
48 };
49 }
57 50
58 assertEquals(2, script_names.length); 51 // Create closure before break point is set.
59 assertEquals("proper_location_1", script_names[0]); 52 var closure = makeClosure();
60 assertEquals("proper_location_2", script_names[1]);
61 53
62 assertEquals("illegal access", exception); 54 // The debugger triggers re-compilation.
55 assertEquals(0, Debug.scriptBreakPoints().length);
56 var scr = Debug.findScript(makeClosure);
57 var sbp = Debug.setScriptBreakPointById(scr.id, 47);
58 assertEquals(1, Debug.scriptBreakPoints().length);
63 59
64 Debug.setListener(null); 60 // Ensure the closure actually triggers a break point hit.
61 closure();
62 assertEquals(1, break_point_hit_count);
63
64 // Remove script break point.
65 assertEquals(1, Debug.scriptBreakPoints().length);
66 Debug.clearBreakPoint(sbp);
67 assertEquals(0, Debug.scriptBreakPoints().length);
OLDNEW
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/mjsunit/debug-script-breakpoints-nested.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698