gyp: move target 'gdk' into chromeos==0

gyp: move target 'gdk' into chromeos==0 because we not use gtk/gdk anymore on ChromeOS.
Add myself to the AUTHORS file.

BUG=None
TEST=Compiled

Contributed by Rene Bolldorf <rb@radix.io>;

Change-Id: Ic3538eb83b59b42dbbb62d9ebc4c4b2fded67011


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142183

[satorux1, 2012-06-13 22:18:50]

Could you explain why this change was necessary? It'd be nice to file a bug at
http://crbug.com and describe the problem you are trying to solve.

BTW, have you committed a change in chromium tree before? Otherwise, you would
need some paperwork:

http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready

[Rene Bolldorf, 2012-06-14 06:21:12]

On 2012/06/13 22:18:50, satorux1 wrote:
> Could you explain why this change was necessary? It'd be nice to file a bug at
> http://crbug.com and describe the problem you are trying to solve.
> 
> BTW, have you committed a change in chromium tree before? Otherwise, you would
> need some paperwork:
> 
> http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready

Chromium for ChromeOS doesn't use gtk/gdk anymore, there is no need to
include/link to it.

[satorux1, 2012-06-14 15:24:21]

On 2012/06/14 06:21:12, Rene Bolldorf wrote:
> On 2012/06/13 22:18:50, satorux1 wrote:
> > Could you explain why this change was necessary? It'd be nice to file a bug
at
> > http://crbug.com and describe the problem you are trying to solve.
> > 
> > BTW, have you committed a change in chromium tree before? Otherwise, you
would
> > need some paperwork:
> > 
> > http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
> 
> Chromium for ChromeOS doesn't use gtk/gdk anymore, there is no need to
> include/link to it.

Thanks. I just checked but libgdk is not linked to 'chrome' as of now.

However, this change is useful to prevent libgdk from getting added back
accidentally. Do you want to pursue this patch? If so, you need to do some
paperwork. See 'Legal' section at
http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready

Please also update the patch description and explain the intention.

[Rene Bolldorf, 2012-06-14 15:41:52]

On 2012/06/14 15:24:21, satorux1 wrote:
> On 2012/06/14 06:21:12, Rene Bolldorf wrote:
> > On 2012/06/13 22:18:50, satorux1 wrote:
> > > Could you explain why this change was necessary? It'd be nice to file a
bug
> at
> > > http://crbug.com and describe the problem you are trying to solve.
> > > 
> > > BTW, have you committed a change in chromium tree before? Otherwise, you
> would
> > > need some paperwork:
> > > 
> > >
http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
> > 
> > Chromium for ChromeOS doesn't use gtk/gdk anymore, there is no need to
> > include/link to it.
> 
> Thanks. I just checked but libgdk is not linked to 'chrome' as of now.
> 
> However, this change is useful to prevent libgdk from getting added back
> accidentally. Do you want to pursue this patch? If so, you need to do some
> paperwork. See 'Legal' section at
> http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
> 
> Please also update the patch description and explain the intention.

Updated.
I've already completed the form, or is something more to do?

[satorux1, 2012-06-14 15:48:15]

On 2012/06/14 15:41:52, Rene Bolldorf wrote:
> On 2012/06/14 15:24:21, satorux1 wrote:
> > On 2012/06/14 06:21:12, Rene Bolldorf wrote:
> > > On 2012/06/13 22:18:50, satorux1 wrote:
> > > > Could you explain why this change was necessary? It'd be nice to file a
> bug
> > at
> > > > http://crbug.com and describe the problem you are trying to solve.
> > > > 
> > > > BTW, have you committed a change in chromium tree before? Otherwise, you
> > would
> > > > need some paperwork:
> > > > 
> > > >
> http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
> > > 
> > > Chromium for ChromeOS doesn't use gtk/gdk anymore, there is no need to
> > > include/link to it.
> > 
> > Thanks. I just checked but libgdk is not linked to 'chrome' as of now.
> > 
> > However, this change is useful to prevent libgdk from getting added back
> > accidentally. Do you want to pursue this patch? If so, you need to do some
> > paperwork. See 'Legal' section at
> > http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready
> > 
> > Please also update the patch description and explain the intention.
> 
> Updated.
> I've already completed the form, or is something more to do?

Please add yourself to AUTHORS file in the top level directory, and include the
change in this patch.

[satorux1, 2012-06-14 16:10:11]

LGTM. Thanks!

[satorux1, 2012-06-14 16:10:28]

You should be able to check the Commit checkbox.

[commit-bot: I haz the power, 2012-06-14 16:11:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rb@radix.io/10543119/6001

[commit-bot: I haz the power, 2012-06-14 16:26:08]

Try job failure for 10543119-6001 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-14 17:29:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rb@radix.io/10543119/6001

[commit-bot: I haz the power, 2012-06-14 18:52:17]

Change committed as 142183