Fix ProcessUtilTests for android.

Fix ProcessUtilTests for android.

On Android, files have to be created in the application directory.

BUG=125059
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141776

[Mark Mentovai, 2012-06-12 19:12:28]

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
File base/process_util_unittest.cc (right):

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
base/process_util_unittest.cc:127: return filename;
Indentation.

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
base/process_util_unittest.cc:131: return tmp_dir.value() + "/" + filename;
Since you have a FilePath, use Append. Don’t build strings yourself with what
you think the path separator is.

[nilesh, 2012-06-12 20:46:10]

Done. PTAL

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
File base/process_util_unittest.cc (right):

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
base/process_util_unittest.cc:127: return filename;
On 2012/06/12 19:12:28, Mark Mentovai wrote:
> Indentation.

Done.

https://chromiumcodereview.appspot.com/10543118/diff/1/base/process_util_unit...
base/process_util_unittest.cc:131: return tmp_dir.value() + "/" + filename;
On 2012/06/12 19:12:28, Mark Mentovai wrote:
> Since you have a FilePath, use Append. Don’t build strings yourself with what
> you think the path separator is.

Done thanks.

[Mark Mentovai, 2012-06-12 20:48:18]

https://chromiumcodereview.appspot.com/10543118/diff/5002/base/process_util_u...
File base/process_util_unittest.cc (right):

https://chromiumcodereview.appspot.com/10543118/diff/5002/base/process_util_u...
base/process_util_unittest.cc:122: static const std::string
GetSignalFilePath(const char* filename);
This doesn’t need to return “const”. There’s no point for it to be const.

[nilesh, 2012-06-12 20:51:43]

http://codereview.chromium.org/10543118/diff/5002/base/process_util_unittest.cc
File base/process_util_unittest.cc (right):

http://codereview.chromium.org/10543118/diff/5002/base/process_util_unittest....
base/process_util_unittest.cc:122: static const std::string
GetSignalFilePath(const char* filename);
On 2012/06/12 20:48:18, Mark Mentovai wrote:
> This doesn’t need to return “const”. There’s no point for it to be const.

Done.

[Mark Mentovai, 2012-06-12 20:57:08]

LGTM

[commit-bot: I haz the power, 2012-06-12 21:08:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10543118/10001

[commit-bot: I haz the power, 2012-06-12 23:06:04]

Change committed as 141776