Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/upload.py

Issue 10543116: Update upload.py to chromium@53dd8c978c1b (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/upload.py
diff --git a/third_party/upload.py b/third_party/upload.py
index 538d3aef31b2544ce65510af843831a5a1bd8ab2..11849fd67ddc885015c74ce138afc666b78c19c0 100755
--- a/third_party/upload.py
+++ b/third_party/upload.py
@@ -1302,12 +1302,16 @@ class GitVCS(VersionControlSystem):
# then the diff of everything except deleted files with rename and copy
# support enabled.
cmd = [
- "git", "diff", "--no-color", "--no-ext-diff", "--full-index", "--ignore-submodules"
+ "git", "diff", "--no-color", "--no-ext-diff", "--full-index",
+ "--ignore-submodules",
]
- diff = RunShell(cmd + ["--diff-filter=D"] + extra_args, env=env,
- silent_ok=True)
- diff += RunShell(cmd + ["-C", "--diff-filter=ACMRT"] + extra_args, env=env,
- silent_ok=True)
+ diff = RunShell(
+ cmd + ["--diff-filter=D"] + extra_args, env=env, silent_ok=True)
+ diff += RunShell(
+ cmd + ["--find-copies-harder", "--diff-filter=ACMRT"] + extra_args,
+ env=env, silent_ok=True)
+ # The CL could be only file deletion or not. So accept silent diff for both
+ # commands then check for an empty diff manually.
if not diff:
ErrorExit("No output from %s" % (cmd + extra_args))
return diff
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698