Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 10543114: NetLogEventParameter to Callback refactoring 2. (Closed)

Created:
8 years, 6 months ago by mmenke
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

NetLogEventParameter to Callback refactoring 2. Get rid of all uses of NetLogEventParameters in net/disk_cache. R=eroman@chromium.org BUG=126243 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141697

Patch Set 1 #

Patch Set 2 : Add include, merge lines #

Total comments: 4

Patch Set 3 : Update comment in response to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -230 lines) Patch
M net/disk_cache/entry_impl.cc View 1 2 9 chunks +9 lines, -12 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 1 2 13 chunks +40 lines, -33 lines 0 comments Download
M net/disk_cache/net_log_parameters.h View 1 2 1 chunk +39 lines, -93 lines 0 comments Download
M net/disk_cache/net_log_parameters.cc View 1 2 1 chunk +82 lines, -79 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 1 2 6 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mmenke
8 years, 6 months ago (2012-06-12 16:47:46 UTC) #1
eroman
lgtm http://codereview.chromium.org/10543114/diff/6002/net/disk_cache/net_log_parameters.cc File net/disk_cache/net_log_parameters.cc (right): http://codereview.chromium.org/10543114/diff/6002/net/disk_cache/net_log_parameters.cc#newcode128 net/disk_cache/net_log_parameters.cc:128: } // namespace disk_cache I wonder why disk_cache ...
8 years, 6 months ago (2012-06-12 16:54:07 UTC) #2
mmenke
Thanks http://codereview.chromium.org/10543114/diff/6002/net/disk_cache/net_log_parameters.cc File net/disk_cache/net_log_parameters.cc (right): http://codereview.chromium.org/10543114/diff/6002/net/disk_cache/net_log_parameters.cc#newcode128 net/disk_cache/net_log_parameters.cc:128: } // namespace disk_cache On 2012/06/12 16:54:07, eroman ...
8 years, 6 months ago (2012-06-12 16:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10543114/10005
8 years, 6 months ago (2012-06-12 16:59:42 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 19:07:22 UTC) #5
Change committed as 141697

Powered by Google App Engine
This is Rietveld 408576698