src/arm/lithium-arm.cc - Issue 10543094: Eliminate redundant smi checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-arm.cc

Issue 10543094: Eliminate redundant smi checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Delay SMI checks as long as possible Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/arm/lithium-arm.cc

diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc

index 569d2954d7ea8cffd8911123cfa53d421d550c89..6b07ee6e66045e50733a09091aecb69a93e7bf9a 100644

--- a/src/arm/lithium-arm.cc

+++ b/src/arm/lithium-arm.cc

@@ -1710,10 +1710,8 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) {

} else {

ASSERT(to.IsInteger32());

LOperand* value = UseRegisterAtStart(instr->value());

- bool needs_check = !instr->value()->type().IsSmi();

- LInstruction* res = NULL;

- if (!needs_check) {

- res = DefineAsRegister(new(zone()) LSmiUntag(value, needs_check));

+ if (instr->value()->IsValueTaggedSmi()) {

+ res = DefineAsRegister(new(zone()) LSmiUntag(value, false));

} else {

LOperand* temp1 = TempRegister();

LOperand* temp2 = instr->CanTruncateToInt32() ? TempRegister()

« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | src/hydrogen-instructions.h » ('J')