Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 10543094: Eliminate redundant smi checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Final review feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/macro-assembler-ia32.cc
diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc
index 5a64b53ef38a75ec751e232f27cdd0241eeebf8b..2012a5ad9d304b0c5c3ebb47c5c4c4283b64d4cc 100644
--- a/src/ia32/macro-assembler-ia32.cc
+++ b/src/ia32/macro-assembler-ia32.cc
@@ -243,8 +243,6 @@ void MacroAssembler::RecordWriteForMap(
Register scratch1,
Register scratch2,
SaveFPRegsMode save_fp) {
- // First, check if a write barrier is even needed. The tests below
- // catch stores of Smis.
Label done;
Register address = scratch1;
@@ -281,7 +279,7 @@ void MacroAssembler::RecordWriteForMap(
Label::kNear);
// Delay the initialization of |address| and |value| for the stub until it's
- // known that the will be needed. Up until this point their value are not
+ // known that the will be needed. Up until this point their values are not
// needed since they are embedded in the operands of instructions that need
// them.
lea(address, FieldOperand(object, HeapObject::kMapOffset));
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698