Issue 10543070: Remove #if from platform app launch code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10543070: Remove #if from platform app launch code. (Closed)

Created:
8 years, 6 months ago by benwells

Modified:
8 years, 6 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove #if from platform app launch code. Convert path to UTF8 using the file_path routine AsUTF8Unsafe, instead of leaving as-is for all OS's except windows where conversion was UTF16ToUTF8. Using the file_path routine is safer, despite its name. This will potentially still have some problems on weird POSIX systems, but should be more robust that the previous #if version. BUG=None TEST=Covered by existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141178