Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 10543058: Slowly transition to the "with api.get_tracer() as tracer:". (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
cmp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Slowly transition to the "with api.get_tracer() as tracer:". This will permit in the end to be able to do multiple traces concurrently. Still not using 'tracename' parameter. NOTRY=true R=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141232

Patch Set 1 #

Patch Set 2 : No need for temp var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M tools/isolate/isolate.py View 1 chunk +6 lines, -5 lines 0 comments Download
M tools/isolate/trace_inputs.py View 1 12 chunks +23 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 6 months ago (2012-06-07 18:58:06 UTC) #1
cmp
lgtm
8 years, 6 months ago (2012-06-08 00:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10543058/3001
8 years, 6 months ago (2012-06-08 16:47:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10543058/3001
8 years, 6 months ago (2012-06-08 16:49:08 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:40:10 UTC) #5
Change committed as 141232

Powered by Google App Engine
This is Rietveld 408576698