Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10543033: Retain the controller in -[DownloadItemButton rightMouseDown:] before opening the menu that targets… (Closed)

Created:
8 years, 6 months ago by Robert Sesek
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays), benjhayden
Visibility:
Public.

Description

Retain the controller in -[DownloadItemButton rightMouseDown:] before opening the menu that targets it. BUG=129826 TEST=See comment #18 in bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/download/download_item_button.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
8 years, 6 months ago (2012-06-06 21:37:02 UTC) #1
Nico
lgtm
8 years, 6 months ago (2012-06-06 21:41:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10543033/1
8 years, 6 months ago (2012-06-06 21:43:02 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-06 22:39:36 UTC) #4
Change committed as 140870

Powered by Google App Engine
This is Rietveld 408576698