Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also.

lib/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBitAnd(HBitAnd node);
   R visitBitNot(HBitNot node);
   R visitBitOr(HBitOr node);
   R visitBitXor(HBitXor node);
@@ skipping 946 matching lines @@
   }
 
   HType get guaranteedType() => HType.BOOLEAN;
 
   accept(HVisitor visitor) => visitor.visitBoolify(this);
   int typeCode() => 0;
   bool typeEquals(other) => other is HBoolify;
   bool dataEquals(HInstruction other) => true;
 }
 
-class HCheck extends HInstruction {
+/**
+ * A [HCheck] instruction is an instruction that might do a dynamic
+ * check at runtime on another instruction. To have proper instruction
+ * dependencies in the graph, instructions that depend on the check
+ * being done reference the [HCheck] instruction instead of the
+ * instruction itself.
+ */
+abstract class HCheck extends HInstruction {
   HCheck(inputs) : super(inputs);
-
-  // TODO(floitsch): make class abstract instead of adding an abstract method.
-  abstract accept(HVisitor visitor);
-
   HInstruction get checkedInput() => inputs[0];
 }
 
-class HTypeGuard extends HCheck {
+/**
+ * A [HCheckStatement] instruction is a [HCheck instruction] that
+ * cannot be generated as an expression.
+ */
+abstract class HCheckStatement extends HCheck {
+  HCheckStatement(inputs) : super(inputs);
+}
+
+class HTypeGuard extends HCheckStatement {
   final int state;
   final HType guardedType;
   bool isOn = false;
   HTypeGuard(this.guardedType, this.state, List<HInstruction> env) : super(env);
 
   void prepareGvn() {
     assert(!hasSideEffects());
     setUseGvn();
   }
 
   HInstruction get guarded() => inputs.last();
   HInstruction get checkedInput() => guarded;
 
   HType computeTypeFromInputTypes() {
     return isOn ? guardedType : guarded.propagatedType;
   }
 
   HType get guaranteedType() => isOn ? guardedType : HType.UNKNOWN;
 
   bool isControlFlow() => true;
 
   accept(HVisitor visitor) => visitor.visitTypeGuard(this);
   int typeCode() => 1;
   bool typeEquals(other) => other is HTypeGuard;
   bool dataEquals(HTypeGuard other) => guardedType == other.guardedType;
 }
 
-class HBoundsCheck extends HCheck {
+class HBoundsCheck extends HCheckStatement {
   static final int ALWAYS_FALSE = 0;
   static final int FULL_CHECK = 1;
   static final int ALWAYS_ABOVE_ZERO = 2;
   static final int ALWAYS_TRUE = 3;
   /**
    * Details which tests have been done statically during compilation.
    * Default is that all checks must be performed dynamically.
    */
   int staticChecks = FULL_CHECK;
 
   HBoundsCheck(length, index) : super(<HInstruction>[length, index]);
 
   HInstruction get length() => inputs[1];
   HInstruction get index() => inputs[0];
   bool isControlFlow() => true;
 
   void prepareGvn() {
     assert(!hasSideEffects());
     setUseGvn();
   }
 
   HType get guaranteedType() => HType.INTEGER;
 
   accept(HVisitor visitor) => visitor.visitBoundsCheck(this);
   int typeCode() => 2;
   bool typeEquals(other) => other is HBoundsCheck;
   bool dataEquals(HInstruction other) => true;
 }
 
-class HIntegerCheck extends HCheck {
+class HIntegerCheck extends HCheckStatement {
   bool alwaysFalse = false;
 
   HIntegerCheck(value) : super(<HInstruction>[value]);
 
   HInstruction get value() => inputs[0];
   bool isControlFlow() => true;
 
   void prepareGvn() {
     assert(!hasSideEffects());
     setUseGvn();
@@ skipping 1519 matching lines @@
   HBasicBlock get start() => expression.start;
   HBasicBlock get end() {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty());
     return statements.last().end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }