Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issue 10543010: Smooth Tab Switching on aura. (Closed)

Created:
8 years, 6 months ago by mmocny
Modified:
8 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Smooth Tab Switching on aura. If there is no available front surface to display when switching to a tab, delay compositing until the next swap which gives us something to display, or some timeout is reached instead. BUG=126526 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141733

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Removing the mouse moves related code since it is likely unnecessary. #

Patch Set 4 : Simplifying this patch since the CompositorLock already nicely resets itself after a timeout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mmocny
This will lock the compositor until the next swap if we dont have a front ...
8 years, 6 months ago (2012-06-05 19:54:45 UTC) #1
mmocny
Simplifying this patch as discussed.
8 years, 6 months ago (2012-06-05 21:17:53 UTC) #2
piman
lgtm
8 years, 6 months ago (2012-06-05 21:20:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/10543010/5002
8 years, 6 months ago (2012-06-05 21:26:08 UTC) #4
commit-bot: I haz the power
Presubmit check for 10543010-5002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-05 21:26:15 UTC) #5
mmocny
Ben: For OWNERS This patch is in anticipation of front surface being released when a ...
8 years, 6 months ago (2012-06-06 14:28:44 UTC) #6
mmocny
Scott, I think Ben is away, may you take a look for OWNERS please?
8 years, 6 months ago (2012-06-12 17:16:49 UTC) #7
sky
LGTM
8 years, 6 months ago (2012-06-12 17:20:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/10543010/5002
8 years, 6 months ago (2012-06-12 19:22:18 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 20:57:45 UTC) #10
Change committed as 141733

Powered by Google App Engine
This is Rietveld 408576698