Issue 10542176: SSL_GetChannelInfo and SSL_GetNegotiatedHostInfo should use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542176: SSL_GetChannelInfo and SSL_GetNegotiatedHostInfo should use (Closed)

Created:
8 years, 6 months ago by wtc

Modified:
8 years, 6 months ago

Reviewers:
agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

SSL_GetChannelInfo and SSL_GetNegotiatedHostInfo should use cwSpec instead of crSpec to support False Start. R=agl@chromium.org BUG=132947 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143015

Patch Set 2 : Add the patch file #

Patch Set 3 : Add the upstream NSS bug number #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
M	net/third_party/nss/README.chromium	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/third_party/nss/patches/applypatches.sh	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/third_party/nss/patches/getchannelinfo.patch	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/sslinfo.c	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

https://chromiumcodereview.appspot.com/10542176/diff/1/net/third_party/nss/ssl/sslinfo.c File net/third_party/nss/ssl/sslinfo.c (right): https://chromiumcodereview.appspot.com/10542176/diff/1/net/third_party/nss/ssl/sslinfo.c#newcode419 net/third_party/nss/ssl/sslinfo.c:419: if (!ss->ssl3.cwSpec->master_secret && !ss->ssl3.cwSpec->msItem.len) { SSL_ExportKeyingMaterial is using cwSpec ...

8 years, 6 months ago (2012-06-15 06:03:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/10542176/6005

8 years, 6 months ago (2012-06-19 18:32:29 UTC) #3

Change committed as 143015