Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10542167: Inline Math.sqrt in new compilers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_ia32.cc
===================================================================
--- runtime/vm/flow_graph_compiler_ia32.cc (revision 8700)
+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)
@@ -71,6 +71,30 @@
}
+void FlowGraphCompiler::GenerateInlinedMathSqrt(Label* done) {
+ Label smi_to_double, double_op, call_method;
+ __ movl(EAX, Address(ESP, 0));
+ __ testl(EAX, Immediate(kSmiTagMask));
+ __ j(ZERO, &smi_to_double);
+ __ CompareClassId(EAX, kDouble, EBX);
+ __ j(NOT_EQUAL, &call_method);
+ __ movsd(XMM1, FieldAddress(EAX, Double::value_offset()));
+ __ Bind(&double_op);
+ __ sqrtsd(XMM0, XMM1);
+ AssemblerMacros::TryAllocate(assembler_,
+ double_class_,
+ &call_method,
+ EAX); // Result register.
+ __ movsd(FieldAddress(EAX, Double::value_offset()), XMM0);
+ __ jmp(done);
+ __ Bind(&smi_to_double);
+ __ SmiUntag(EAX);
+ __ cvtsi2sd(XMM1, EAX);
+ __ jmp(&double_op);
+ __ Bind(&call_method);
+}
+
+
void FlowGraphCompiler::GenerateCallRuntime(intptr_t cid,
intptr_t token_index,
intptr_t try_index,
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.h ('k') | runtime/vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698