Issue 10542150: Actually free plugin implement vars when running out of process when the

Issue 10542150: Actually free plugin implement vars when running out of process when the (Closed)

Created:
8 years, 6 months ago by brettw

Modified:
8 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Actually free plugin implement vars when running out of process when the plugin holds a reference beyond the lifetime of the instance. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142787

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+332 lines, -15 lines)			Patch
M	ppapi/c/dev/ppb_var_deprecated.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_var_tracker.h	View	1	4 chunks	+77 lines, -0 lines	0 comments	Download
M	ppapi/proxy/plugin_var_tracker.cc	View	1 2 3 4 5	3 chunks	+90 lines, -0 lines	0 comments	Download
M	ppapi/proxy/plugin_var_tracker_unittest.cc	View	1 2	3 chunks	+81 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppp_class_proxy.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppp_class_proxy.cc	View	1 2 3 4	10 chunks	+37 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppp_instance_proxy.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	ppapi/proxy/proxy_object_var.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ppapi/proxy/proxy_object_var.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/shared_impl/test_globals.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/var_tracker.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/host_var_tracker.h	View	1 2 3 4	1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/host_var_tracker.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

http://codereview.chromium.org/10542150/diff/11002/ppapi/proxy/plugin_var_tracker.cc File ppapi/proxy/plugin_var_tracker.cc (right): http://codereview.chromium.org/10542150/diff/11002/ppapi/proxy/plugin_var_tracker.cc#newcode165 ppapi/proxy/plugin_var_tracker.cc:165: UserDataToPluginImplementedVarMap::iterator next = i; I think it'd be clearer ...

8 years, 6 months ago (2012-06-15 21:45:24 UTC) #4

viettrungluu

http://codereview.chromium.org/10542150/diff/15001/ppapi/shared_impl/var_tracker.h File ppapi/shared_impl/var_tracker.h (right): http://codereview.chromium.org/10542150/diff/15001/ppapi/shared_impl/var_tracker.h#newcode37 ppapi/shared_impl/var_tracker.h:37: #if 1//def ENABLE_PEPPER_THREADING wtf?

8 years, 6 months ago (2012-06-15 21:55:52 UTC) #5

viettrungluu

http://codereview.chromium.org/10542150/diff/15001/ppapi/proxy/ppp_class_proxy.cc File ppapi/proxy/ppp_class_proxy.cc (right): http://codereview.chromium.org/10542150/diff/15001/ppapi/proxy/ppp_class_proxy.cc#newcode334 ppapi/proxy/ppp_class_proxy.cc:334: Nit: Why does this method deserve an extra blank ...

8 years, 6 months ago (2012-06-15 21:58:01 UTC) #6

viettrungluu

8 years, 6 months ago (2012-06-15 22:04:15 UTC) #8

http://codereview.chromium.org/10542150/diff/26001/ppapi/proxy/plugin_var_tra...
File ppapi/proxy/plugin_var_tracker.cc (right):

http://codereview.chromium.org/10542150/diff/26001/ppapi/proxy/plugin_var_tra...
ppapi/proxy/plugin_var_tracker.cc:10: #include
"ppapi/c/dev/ppp_class_deprecated.h"
But wait, there's more! Lint tells us that this isn't in alphabetical order.

Expand Messages | Collapse Messages