src/url_util.cc - Issue 10542140: Fix handling of URLs with no schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/url_util.cc

Issue 10542140: Fix handling of URLs with no schema. (Closed) Base URL: http://git.chromium.org/external/google-url.git@master

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/url_util.cc

diff --git a/src/url_util.cc b/src/url_util.cc

index 382cec278499e05bc223207ab8ed8cf16052c070..04c595a3ba9fa6fc9a52b6952a946ced6da09692 100644

--- a/src/url_util.cc

+++ b/src/url_util.cc

@@ -178,8 +178,10 @@ bool DoCanonicalize(const CHAR* in_spec, int in_spec_len,

#endif

url_parse::Component scheme;

- if (!url_parse::ExtractScheme(spec, spec_len, &scheme))

+ if (!url_parse::ExtractScheme(spec, spec_len, &scheme)) {

+ AppendInvalidNarrowString(spec, 0, spec_len, output);

return false;

+ }

// This is the parsed version of the input URL, we have to canonicalize it

// before storing it in our object.

« no previous file with comments | « src/gurl_unittest.cc ('k') | no next file » | no next file with comments »