Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 10542128: Return the results of Append in ChunkDemuxer::On{Audio,Video}Buffers() (Closed)

Created:
8 years, 6 months ago by annacc
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Return the results of Append in ChunkDemuxer::On{Audio,Video}Buffers() We weren't able to successfully return results until overlaps etc. were properly computed in SourceBufferStream::Append(). That's fixed now (http://crbug.com/125072), so let's start returning! BUG=132314 TEST=media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141767

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M media/filters/chunk_demuxer.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
annacc
Quick fixeroo.
8 years, 6 months ago (2012-06-12 20:35:15 UTC) #1
vrk (LEFT CHROMIUM)
lgtm
8 years, 6 months ago (2012-06-12 20:54:40 UTC) #2
acolwell GONE FROM CHROMIUM
LGTM
8 years, 6 months ago (2012-06-12 20:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annacc@chromium.org/10542128/3001
8 years, 6 months ago (2012-06-12 21:02:31 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 22:50:21 UTC) #5
Change committed as 141767

Powered by Google App Engine
This is Rietveld 408576698