Avoid leaking any files from SQLiteFeaturesTest.

Avoid leaking any files from SQLiteFeaturesTest.

Patch from Pavel Ivanov <paivanof@gmail.com>;

BUG=130498
TEST=On Linux /tmp/SQLStatementTest.db-journal is not left after execution.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141849

[Scott Hess - ex-Googler, 2012-06-12 03:20:35]

LGTM!  Thanks for catching this!

[Scott Hess - ex-Googler, 2012-06-12 03:21:27]

On 2012/06/12 03:20:35, shess wrote:
> LGTM!  Thanks for catching this!

I assume you'd like me to land this?  I'll wait until you respond affirmatively.

[pivanof, 2012-06-12 03:32:10]

On 2012/06/12 03:21:27, shess wrote:
> On 2012/06/12 03:20:35, shess wrote:
> > LGTM!  Thanks for catching this!
> 
> I assume you'd like me to land this?  I'll wait until you respond
affirmatively.

Yes, I'd like you to land this.

[commit-bot: I haz the power, 2012-06-12 18:17:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/paivanof@gmail.com/10542096/1

[commit-bot: I haz the power, 2012-06-12 18:18:00]

Failed to apply patch for AUTHORS:
While running patch -p0 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 186.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[Scott Hess - ex-Googler, 2012-06-12 18:19:41]

On 2012/06/12 18:18:00, I haz the power (commit-bot) wrote:
> Failed to apply patch for AUTHORS:
> While running patch -p0 --forward --force;
> patching file AUTHORS
> Hunk #1 FAILED at 186.
> 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

I just manually landed a patch for someone that the commit queue wasn't
grokking, so it's probably a conflict with that.  I'll rebase.

[Scott Hess - ex-Googler, 2012-06-12 19:17:38]

On 2012/06/12 18:19:41, shess wrote:
> On 2012/06/12 18:18:00, I haz the power (commit-bot) wrote:
> > Failed to apply patch for AUTHORS:
> > While running patch -p0 --forward --force;
> > patching file AUTHORS
> > Hunk #1 FAILED at 186.
> > 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej
> 
> I just manually landed a patch for someone that the commit queue wasn't
> grokking, so it's probably a conflict with that.  I'll rebase.

Sigh.  git cl upload tells me that I'm not the owner.  I suppose that's fair,
but it means I can't rebase from my end.  Could you from your end?  Basically,
you just need to git fetch origin, git rebase origin/master [your branch], and
git cl upload again.  It'll show a conflict in AUTHORS, just keep both versions.

Otherwise I can land it as a new CL.

[pivanof, 2012-06-12 19:24:29]

> Sigh.  git cl upload tells me that I'm not the owner.  I suppose that's fair,
> but it means I can't rebase from my end.  Could you from your end?  Basically,
> you just need to git fetch origin, git rebase origin/master [your branch], and
> git cl upload again.  It'll show a conflict in AUTHORS, just keep both
versions.
> 
> Otherwise I can land it as a new CL.

I can do that later tonight.

Looking at the conflicting commit I guess I should also exclude "Patch from..."
from description as it will be automatically added when you'll commit it, right?

[Scott Hess - ex-Googler, 2012-06-12 19:27:46]

On 2012/06/12 19:24:29, pivanof wrote:
> > Sigh.  git cl upload tells me that I'm not the owner.  I suppose that's
fair,
> > but it means I can't rebase from my end.  Could you from your end? 
Basically,
> > you just need to git fetch origin, git rebase origin/master [your branch],
and
> > git cl upload again.  It'll show a conflict in AUTHORS, just keep both
> versions.
> > 
> > Otherwise I can land it as a new CL.
> 
> I can do that later tonight.
> 
> Looking at the conflicting commit I guess I should also exclude "Patch
from..."
> from description as it will be automatically added when you'll commit it,
right?

The other commit didn't work with the commit-queue, so I had to land it
manually, so I don't know for certain what will be added or not.  I'd just leave
it.  Duplication won't hurt anyone.

Thanks,
scott

[pivanof, 2012-06-13 00:43:15]

I've rebased.

[commit-bot: I haz the power, 2012-06-13 01:31:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/paivanof@gmail.com/10542096/5002

[commit-bot: I haz the power, 2012-06-13 01:35:51]

Try job failure for 10542096-5002 (retry) on mac_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-06-13 01:50:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/paivanof@gmail.com/10542096/5002

[commit-bot: I haz the power, 2012-06-13 03:31:17]

Change committed as 141849