Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10542089: Power save blocker: switch to new implementation. (Closed)

Created:
8 years, 6 months ago by Mike Mammarella
Modified:
8 years, 6 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, sky, satorux1, Nico, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Power save blocker: switch to new implementation. In addition to making things much simpler, this will also fix bug 126591 on Windows 8 by activating the new code in r140668. BUG=126591 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141433

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -723 lines) Patch
M content/browser/download/download_file_impl.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_manager.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/power_save_blocker.h View 3 chunks +6 lines, -50 lines 0 comments Download
M content/browser/power_save_blocker_android.cc View 1 1 chunk +17 lines, -3 lines 0 comments Download
D content/browser/power_save_blocker_common.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M content/browser/power_save_blocker_linux.cc View 1 chunk +0 lines, -475 lines 0 comments Download
M content/browser/power_save_blocker_mac.cc View 1 2 5 chunks +18 lines, -82 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 2 chunks +1 line, -27 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +7 lines, -5 lines 1 comment Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_file_error_injector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike Mammarella
8 years, 6 months ago (2012-06-09 00:58:24 UTC) #1
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10542089/diff/2004/content/browser/power_save_blocker_mac.cc File content/browser/power_save_blocker_mac.cc (right): https://chromiumcodereview.appspot.com/10542089/diff/2004/content/browser/power_save_blocker_mac.cc#newcode33 content/browser/power_save_blocker_mac.cc:33: g_power_thread2 = LAZY_INSTANCE_INITIALIZER; Now that g_power_thread is gone, can ...
8 years, 6 months ago (2012-06-09 01:06:26 UTC) #2
Mike Mammarella
https://chromiumcodereview.appspot.com/10542089/diff/2004/content/browser/power_save_blocker_mac.cc File content/browser/power_save_blocker_mac.cc (right): https://chromiumcodereview.appspot.com/10542089/diff/2004/content/browser/power_save_blocker_mac.cc#newcode33 content/browser/power_save_blocker_mac.cc:33: g_power_thread2 = LAZY_INSTANCE_INITIALIZER; On 2012/06/09 01:06:26, Avi wrote: > ...
8 years, 6 months ago (2012-06-09 01:14:31 UTC) #3
Avi (use Gerrit)
lgtm
8 years, 6 months ago (2012-06-09 02:49:49 UTC) #4
rvargas (doing something else)
LGTM http://codereview.chromium.org/10542089/diff/6004/content/browser/download/download_file_manager.cc File content/browser/download/download_file_manager.cc (right): http://codereview.chromium.org/10542089/diff/6004/content/browser/download/download_file_manager.cc#newcode63 content/browser/download/download_file_manager.cc:63: "Downloading")).Pass(), nit: Can we say something like "download ...
8 years, 6 months ago (2012-06-09 19:53:19 UTC) #5
Mike Mammarella
http://codereview.chromium.org/10542089/diff/6004/content/browser/download/download_file_manager.cc File content/browser/download/download_file_manager.cc (right): http://codereview.chromium.org/10542089/diff/6004/content/browser/download/download_file_manager.cc#newcode63 content/browser/download/download_file_manager.cc:63: "Downloading")).Pass(), On 2012/06/09 19:53:19, rvargas wrote: > nit: Can ...
8 years, 6 months ago (2012-06-10 01:09:49 UTC) #6
rvargas (doing something else)
Still LGTM
8 years, 6 months ago (2012-06-11 17:04:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/10542089/3006
8 years, 6 months ago (2012-06-11 17:05:29 UTC) #8
commit-bot: I haz the power
Change committed as 141433
8 years, 6 months ago (2012-06-11 18:02:05 UTC) #9
jam
8 years, 6 months ago (2012-06-12 20:53:32 UTC) #10 
https://chromiumcodereview.appspot.com/10542089/diff/3006/content/browser/ren...
File content/browser/renderer_host/render_view_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10542089/diff/3006/content/browser/ren...
content/browser/renderer_host/render_view_host_impl.cc:1771:
content::PowerSaveBlocker* blocker = NULL;
nit: in this whole function, don't add "content::" since you're in the content
namespace

Powered by Google App Engine
This is Rietveld 408576698