Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: content/browser/geolocation/libgps_wrapper_linux.cc

Issue 10542081: Coverity: Restructure logically dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/geolocation/libgps_wrapper_linux.cc
diff --git a/content/browser/geolocation/libgps_wrapper_linux.cc b/content/browser/geolocation/libgps_wrapper_linux.cc
index f140335caac4dfe9d46751befcf272ba0f46752a..5d108a38a08209d8b33a856c24a92d418dee4c7a 100644
--- a/content/browser/geolocation/libgps_wrapper_linux.cc
+++ b/content/browser/geolocation/libgps_wrapper_linux.cc
@@ -81,14 +81,14 @@ bool LibGps::Start() {
// See gps.h NL_NOxxx for definition of gps_open() error numbers.
DLOG(WARNING) << "gps_open() failed " << errno;
return false;
+ } else {
+ is_open_ = true;
+ return true;
}
#else // drop the support for desktop linux for now
DLOG(WARNING) << "LibGps is only supported on ChromeOS";
return false;
#endif
-
- is_open_ = true;
- return true;
}
void LibGps::Stop() {
if (is_open_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698