Implement Smi binops ia32 (new compiler).

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 797 matching lines @@
     LocationSummary* summary = new LocationSummary(kNumInputs, kNumTemps);
     summary->set_in(0, Location::RequiresRegister());
     summary->set_in(1, Location::RequiresRegister());
     summary->set_out(Location::SameAsFirstInput());
     summary->set_temp(0, Location::RequiresRegister());
     return summary;
   }
 }
 
 
-// TODO(srdjan): Implement variations.
 static void EmitSmiBinaryOp(FlowGraphCompiler* compiler, BinaryOpComp* comp) {
-  // TODO(srdjan): need to allocate a temporary register (now using r10)
   Register left = comp->locs()->in(0).reg();
   Register right = comp->locs()->in(1).reg();
   Register result = comp->locs()->out().reg();
   Register temp = comp->locs()->temp(0).reg();
   ASSERT(left == result);
   Label* deopt = compiler->AddDeoptStub(comp->instance_call()->cid(),
                                         comp->instance_call()->token_index(),
                                         comp->instance_call()->try_index(),
                                         kDeoptSmiBinaryOp,
                                         temp,
@@ skipping 52 matching lines @@
       __ cqo();  // Sign extend RAX -> RDX:RAX.
       __ idivq(right_temp);  //  RAX: quotient, RDX: remainder.
       // Check the corner case of dividing the 'MIN_SMI' with -1, in which
       // case we cannot tag the result.
       __ cmpq(result, Immediate(0x4000000000000000));
       __ j(EQUAL, deopt);
       __ SmiTag(result);
       break;
     }
     case Token::kSHR: {
-      const Immediate kCountLimit = Immediate(0x1F);
+      // sarq operation masks the count to 6 bits.
+      const Immediate kCountLimit = Immediate(0x3F);
       __ cmpq(right, Immediate(0));
       __ j(LESS, deopt);
       __ SmiUntag(right);
       __ cmpq(right, kCountLimit);
       Label count_ok;
       __ j(LESS, &count_ok, Assembler::kNearJump);
       __ movq(right, kCountLimit);
       __ Bind(&count_ok);
-      ASSERT(right == RCX);  // Count must be in ECX
+      ASSERT(right == RCX);  // Count must be in RCX
       __ SmiUntag(left);
       __ sarq(left, right);
       __ SmiTag(left);
       break;
     }
     case Token::kSHL: {
       // Check if count too large for handling it inlined.
       __ cmpq(right,
           Immediate(reinterpret_cast<int64_t>(Smi::New(Smi::kBits))));
       __ j(ABOVE_EQUAL, deopt);
@@ skipping 28 matching lines @@
       UNREACHABLE();
       break;
     }
     default:
       UNREACHABLE();
       break;
   }
 }
 
 
-static bool EmitDoubleBinaryOp(FlowGraphCompiler* compiler,
+static void EmitDoubleBinaryOp(FlowGraphCompiler* compiler,
                                BinaryOpComp* comp) {
   Register left = comp->locs()->in(0).reg();
   Register right = comp->locs()->in(1).reg();
   Register temp = comp->locs()->temp(0).reg();
   Register result = comp->locs()->out().reg();
 
 
   const Class& double_class =
       Class::ZoneHandle(Isolate::Current()->object_store()->double_class());
   const Code& stub =
@@ skipping 22 matching lines @@
 
   switch (comp->op_kind()) {
     case Token::kADD: __ addsd(XMM0, XMM1); break;
     case Token::kSUB: __ subsd(XMM0, XMM1); break;
     case Token::kMUL: __ mulsd(XMM0, XMM1); break;
     case Token::kDIV: __ divsd(XMM0, XMM1); break;
     default: UNREACHABLE();
   }
 
   __ movsd(FieldAddress(result, Double::value_offset()), XMM0);
-  return true;
 }
 
 
 void BinaryOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   switch (operands_type()) {
     case kSmiOperands:
       EmitSmiBinaryOp(compiler, this);
       break;
 
     case kDoubleOperands:
@@ skipping 114 matching lines @@
   } else {
     UNREACHABLE();
   }
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64