RFC: Resolution based tree-shaking.

dart/lib/compiler/implementation/enqueue.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class EnqueueTask extends CompilerTask {
   final Enqueuer codegen;
   final Enqueuer resolution;
 
   String get name() => 'Enqueue';
 
   EnqueueTask(Compiler compiler)
     : codegen = new Enqueuer(compiler),
       resolution = new Enqueuer(compiler),
       super(compiler) {
     codegen.task = this;
     resolution.task = this;
   }
 }
 
 class Enqueuer {
   final Compiler compiler; // TODO(ahe): Remove this dependency.
   final Map<String, Link<Element>> instanceMembersByName;
   final Set<ClassElement> seenClasses;
   final Universe universe;
   final Queue<WorkItem> queue;
+  final Map<Element, TreeElements> resolvedElements;
   bool queueIsClosed = false;
   EnqueueTask task;
 
   Enqueuer(this.compiler)
     : instanceMembersByName = new Map<String, Link<Element>>(),
       seenClasses = new Set<ClassElement>(),
       universe = new Universe(),
-      queue = new Queue<WorkItem>();
+      queue = new Queue<WorkItem>(),
+      resolvedElements = new Map<Element, TreeElements>();
+
+  bool get isFirstQueue() => compiler.enqueuer.resolution === this;

[ngeoffray, 2012/06/12 12:44:14]

isResolutionQueue?

[ahe, 2012/06/12 18:47:13]

Done.

+
+  TreeElements getCachedElements(Element element) {
+    Element owner = element.getOutermostEnclosingMemberOrTopLevel();
+    return compiler.enqueuer.resolution.resolvedElements[owner];
+  }
 
   void addToWorkList(Element element, [TreeElements elements]) {
+    if (element.isForeign()) return;
     if (queueIsClosed) {
+      if (isFirstQueue && getCachedElements(element) !== null) return;
       compiler.internalErrorOnElement(element, "Work list is closed.");
     }
-    if (element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
+    if (!isFirstQueue && element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
       registerInstantiatedClass(element.enclosingElement);
     }
+    if (elements === null) {
+      elements = getCachedElements(element);
+    }
     queue.add(new WorkItem(element, elements));
   }
 
   void registerInstantiatedClass(ClassElement cls) {
+    if (cls.isInterface()) {
+      compiler.internalErrorOnElement(
+          // Use the current element, as this is where cls is referenced from.
+          compiler.currentElement,
+          'Expected a class, but $cls is an interface.');
+    }
     universe.instantiatedClasses.add(cls);
     onRegisterInstantiatedClass(cls);
   }
 
   bool checkNoEnqueuedInvokedInstanceMethods() {
     task.measure(() {
       // Run through the classes and see if we need to compile methods.
       for (ClassElement classElement in universe.instantiatedClasses) {
         for (ClassElement currentClass = classElement;
              currentClass !== null;
@@ skipping 23 matching lines @@
           for (Selector selector in invokedSelectors) {
             registerDynamicInvocation(Namer.CLOSURE_INVOCATION_NAME, selector);
           }
         }
       }
     });
   }
 
   void processInstantiatedClassMember(Element member) {
     if (universe.generatedCode.containsKey(member)) return;
+    if (resolvedElements[member] !== null) return;
 
     if (!member.isInstanceMember()) return;
     if (member.isField()) return;
 
     String memberName = member.name.slowToString();
     Link<Element> members = instanceMembersByName.putIfAbsent(
         memberName, () => const EmptyLink<Element>());
     instanceMembersByName[memberName] = members.prepend(member);
 
     if (member.kind === ElementKind.GETTER ||
@@ skipping 137 matching lines @@
       registerNewSelector(setterName,
                           new TypedSelector(type, Selector.SETTER),
                           universe.fieldSetters);
     });
   }
 
   // TODO(ngeoffray): This should get a type.
   void registerIsCheck(Element element) {
     universe.isChecks.add(element);
   }
+
+  void forEach(f(WorkItem work)) {
+    while (!queue.isEmpty()) {
+      f(queue.removeLast());
+    }
+  }
 }