Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 10542063: Roll out http://crrev.com/140760 , because we encountered errors when rebaselining in webkit. (Closed)

Created:
8 years, 6 months ago by epoger
Modified:
8 years, 6 months ago
Reviewers:
reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Roll out http://crrev.com/140760 , because we encountered errors when rebaselining in webkit. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141216

Patch Set 1 #

Patch Set 2 : add_chromium_testexpectations_with_new_failures #

Patch Set 3 : moved_tighter_overrides_back_into_skia_test_expectations #

Patch Set 4 : updated_to_141203 #

Patch Set 5 : added_more_expected_failures_based_on_patch4_trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -1829 lines) Patch
M skia/skia.gyp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 2 3 4 1 chunk +330 lines, -1829 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Based on the trybot results from patchset 3 (which ran late yesterday), I think this ...
8 years, 6 months ago (2012-06-08 13:46:32 UTC) #1
reed1
lgtm
8 years, 6 months ago (2012-06-08 14:15:17 UTC) #2
epoger
On 2012/06/08 13:46:32, epoger wrote: > Based on the trybot results from patchset 3 (which ...
8 years, 6 months ago (2012-06-08 14:15:57 UTC) #3
epoger
8 years, 6 months ago (2012-06-08 16:05:35 UTC) #4
On 2012/06/08 14:15:57, epoger wrote:
> Note that the linux_layout_rel trybot has already caught one new failure. 
Once
> we have trybot results for all 3 platforms, I will update the expectations.

The windows trybots found 263 more failures... ugh.

I folded all of those new failures into skia_test_expectations.txt and landed
it.  Hopefully not too many other failures have snuck in over the past hour...

I'll keep a close eye on the waterfall bots and deal with any remaining
failures.

Powered by Google App Engine
This is Rietveld 408576698