Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chrome/browser/chromeos/input_method/candidate_window_view.h

Issue 10542051: Reduce candidate window flickering. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Leave todo comment. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/candidate_window.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_
6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_ 6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_
7 7
8 #include "base/gtest_prod_util.h" 8 #include "base/gtest_prod_util.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/timer.h" 10 #include "base/timer.h"
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 // This location is used by suggestion window rendering which is mostly used 200 // This location is used by suggestion window rendering which is mostly used
201 // by ibus-mozc. The suggestion window should be aligned with the composition 201 // by ibus-mozc. The suggestion window should be aligned with the composition
202 // text as opposed to the cursor. In case of ibus-mozc, suggestion window 202 // text as opposed to the cursor. In case of ibus-mozc, suggestion window
203 // location is calculated by engine and it carried by update_lookup_table 203 // location is calculated by engine and it carried by update_lookup_table
204 // signal as additional information. This value is available when 204 // signal as additional information. This value is available when
205 // is_suggestion_window_available is true. 205 // is_suggestion_window_available is true.
206 gfx::Rect suggestion_window_location_; 206 gfx::Rect suggestion_window_location_;
207 207
208 bool is_suggestion_window_location_available_; 208 bool is_suggestion_window_location_available_;
209 209
210 // True if the candidate window should be shonw on the upper side of
211 // composition text.
212 bool should_show_upper_side_;
213
210 // True if the candidate window was open. This is used to determine when to 214 // True if the candidate window was open. This is used to determine when to
211 // send OnCandidateWindowOpened and OnCandidateWindowClosed events. 215 // send OnCandidateWindowOpened and OnCandidateWindowClosed events.
212 bool was_candidate_window_open_; 216 bool was_candidate_window_open_;
213 217
214 // This function judge whether the candidate window should be shown or not, 218 // This function judge whether the candidate window should be shown or not,
215 // if should be, shows parent_frame and if not, hides parent_frame. 219 // if should be, shows parent_frame and if not, hides parent_frame.
216 void UpdateParentArea(); 220 void UpdateParentArea();
217 221
218 DISALLOW_COPY_AND_ASSIGN(CandidateWindowView); 222 DISALLOW_COPY_AND_ASSIGN(CandidateWindowView);
219 }; 223 };
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 const mozc::commands::InformationList* old_usages, 273 const mozc::commands::InformationList* old_usages,
270 const mozc::commands::InformationList* new_usages); 274 const mozc::commands::InformationList* new_usages);
271 275
272 DISALLOW_COPY_AND_ASSIGN(InfolistWindowView); 276 DISALLOW_COPY_AND_ASSIGN(InfolistWindowView);
273 }; 277 };
274 278
275 } // namespace input_method 279 } // namespace input_method
276 } // namespace chromeos 280 } // namespace chromeos
277 281
278 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_ 282 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_CANDIDATE_WINDOW_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/input_method/candidate_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698