Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: chrome/browser/shell_integration_unittest.cc

Issue 10542031: Suffix Chrome's appid on user-level installs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to r142814 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration.h ('k') | chrome/browser/shell_integration_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration_unittest.cc
diff --git a/chrome/browser/shell_integration_unittest.cc b/chrome/browser/shell_integration_unittest.cc
index 714e295096e6ae0e3135d85e23a09989bf82709d..b6168c7a40c607cdc979b0d5059dcc7c35244f04 100644
--- a/chrome/browser/shell_integration_unittest.cc
+++ b/chrome/browser/shell_integration_unittest.cc
@@ -365,27 +365,31 @@ TEST(ShellIntegrationTest, GetDesktopFileContents) {
}
}
#elif defined(OS_WIN)
-TEST(ShellIntegrationTest, GetChromiumAppIdTest) {
+TEST(ShellIntegrationTest, GetAppModelIdForProfileTest) {
+ const string16 base_app_id(
+ BrowserDistribution::GetDistribution()->GetBaseAppId());
+
// Empty profile path should get chrome::kBrowserAppID
FilePath empty_path;
- EXPECT_EQ(BrowserDistribution::GetDistribution()->GetBrowserAppId(),
- ShellIntegration::GetChromiumAppId(empty_path));
+ EXPECT_EQ(base_app_id,
+ ShellIntegration::GetAppModelIdForProfile(base_app_id, empty_path));
// Default profile path should get chrome::kBrowserAppID
FilePath default_user_data_dir;
chrome::GetDefaultUserDataDirectory(&default_user_data_dir);
FilePath default_profile_path =
default_user_data_dir.AppendASCII(chrome::kInitialProfile);
- EXPECT_EQ(BrowserDistribution::GetDistribution()->GetBrowserAppId(),
- ShellIntegration::GetChromiumAppId(default_profile_path));
+ EXPECT_EQ(base_app_id,
+ ShellIntegration::GetAppModelIdForProfile(base_app_id,
+ default_profile_path));
// Non-default profile path should get chrome::kBrowserAppID joined with
// profile info.
FilePath profile_path(FILE_PATH_LITERAL("root"));
profile_path = profile_path.Append(FILE_PATH_LITERAL("udd"));
profile_path = profile_path.Append(FILE_PATH_LITERAL("User Data - Test"));
- EXPECT_EQ(BrowserDistribution::GetDistribution()->GetBrowserAppId() +
- L".udd.UserDataTest",
- ShellIntegration::GetChromiumAppId(profile_path));
+ EXPECT_EQ(base_app_id + L".udd.UserDataTest",
+ ShellIntegration::GetAppModelIdForProfile(base_app_id,
+ profile_path));
}
#endif
« no previous file with comments | « chrome/browser/shell_integration.h ('k') | chrome/browser/shell_integration_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698