Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7313)

Unified Diff: chrome/installer/util/shell_util.h

Issue 10542031: Suffix Chrome's appid on user-level installs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ShellUtil::ConstructAppModelId() and some renaming Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index de06322a0526d36037f7176a7017d4a532d342dd..1a84baede52f6f1f50134f1a4ea2384acc9be194 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -242,6 +242,20 @@ class ShellUtil {
static string16 GetApplicationName(BrowserDistribution* dist,
const string16& chrome_exe);
+ // Returns the AppUserModelId for |dist|. This identifier is unconditionally
+ // suffixed with the user id for user-level installs (in contrast to other
+ // registration entries which are suffix as described in
+ // GetCurrentInstallationSuffix() above).
+ static string16 GetChromiumModelId(BrowserDistribution* dist,
grt (UTC plus 2) 2012/06/18 19:45:08 Hmm. I like GetAppId better, since |dist| might n
gab 2012/06/18 21:52:43 I did this to reflect the call sites in ShellInteg
+ const string16& chrome_exe);
+
+ // Returns an AppUserModelId composed of each member of |components| separated
+ // by dots.
+ // The returned appid is guaranteed to be no longer than
+ // chrome::kMaxAppModelIdLength (some of the components might have been
+ // truncated to enforce this).
+ static string16 ConstructAppModelId(const std::vector<string16>& components);
+
// Make Chrome the default browser. This function works by going through
// the url protocols and file associations that are related to general
// browsing, e.g. http, https, .html etc., and requesting to become the

Powered by Google App Engine
This is Rietveld 408576698